Ong Larson 2026 coriolis test ekman#21
Open
HingOng wants to merge 2 commits intolarson-group:masterfrom
Open
Conversation
LarsonGroupSysAdmin
force-pushed
the
master
branch
from
d2bd898 to
f1b6cfe
Compare
vlarson
reviewed
Jan 25, 2026
| w_tol = 2.e-2_core_rknd, & ! [m/s] | ||
| thl_tol = 1.e-2_core_rknd, & ! [K] | ||
| rt_tol = max( 1.e-8_core_rknd, epsilon(pi) ), & ! [kg/kg] | ||
| thl_tol = zero, & ! 1.e-2_core_rknd, & ! [K] |
Contributor
There was a problem hiding this comment.
@huebleruwm, I'm not sure what's the easiest way to make the value of thl_tol adjustable in a namelist. I suppose we could introduce a preprocessor flag or else move thl_tol out of constants_clubb.F90. Neither seems ideal.
vlarson
reviewed
Feb 9, 2026
| ! fcor could reasonably be defined as below, but currently it is input via namelist | ||
| ! Hing Ong, 25 November 2025 | ||
| !fcor = two * omega_planet * sin ( lat_vals * radians_per_deg ) | ||
| fcor = two * omega_planet * sin ( lat_vals * radians_per_deg ) |
Contributor
There was a problem hiding this comment.
@huebleruwm, I'm also not sure how to make available this option for the definition of fcor. How hard would this be?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch can be used to reproduce the results in Sections 2 and 3 of Ong and Larson (2026) paper (draft)