Skip to content

Use constant time lookups in Figaro::ENV#get_value method #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
steventen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use constant time lookups in Figaro::ENV#get_value method #237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6181ba5
Replace with constant time lookups for a given key.
steventen Apr 26, 2016
a3cb715
Use has_key? method for constant lookup.
steventen Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/figaro/env.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@ def extract_key_from_method(method)
end

def has_key?(key)
::ENV.any? { |k, _| k.downcase == key }
::ENV.has_key?(key) || ::ENV.has_key?(key.upcase)
end

def missing_key!(key)
raise MissingKey.new(key)
end

def get_value(key)
_, value = ::ENV.detect { |k, _| k.downcase == key }
value
::ENV[key] || ::ENV[key.upcase]
end
end
end