Conversation
scott-white-kin
left a comment
There was a problem hiding this comment.
I have the same issue and this looks like a good fix
|
This would fix on new versions but maybe crash on older versions, i think you should check the RUBY_VERSION, because old ruby versions still use .exists? |
|
Any chance of this being merged soon? Have to work with a fork otherwise. Thanks :) |
|
A merge would be quite nice |
|
I think this should already be merged, I almost wanted to create a new PR for the same Issue, can someone please merge this PR thanks :) |
The "exist?" method is also valid for old Ruby versions. The repository is using it in some files. cc @laserlemon. |
|
I believe the new alternative in 7+ is Pathname.new(path_name).exist? |
|
This was fixed in #294 so this PR can be closed. |
-Fix typo in the ignore_configuration method
This pull request fixes a typo in the
ignore_configurationmethod of the project's codebase. The current implementation usesFile.exists?to check if a.gitignorefile exists, which should be replaced withFile.exist?for consistency with Ruby's standard library.I have tested this change on my local machine and confirmed that it resolves the issue.