Conversation
|
|
||
| # Get orbit folder | ||
| orbfold = orbit_folder(iuvs_orbno_from_fname(l1a_fname)) | ||
| from maven_iuvs.download import get_default_data_directory |
There was a problem hiding this comment.
I believe imports are required to be at the top of the file or it will throw an error
There was a problem hiding this comment.
It needs to be here to avoid a circular import error, but this should be explicitly noted with a comment rather than implied.
There was a problem hiding this comment.
Ah, you can also import the download.py module as an alias, like:
# miscellaneous.py:
import maven_iuvs.download as dl
...
blah = dl.get_default_data_directory('l1a')But this is not the most elegant since it imports the whole module. At any rate, I have something like this in echelle.py and echelle_graphics.py to avoid the same problem, but that's probably better addressed by eventually splitting up the quicklook vs. line fitting codes.
There was a problem hiding this comment.
To clarify, @JadenStrom please add either a comment to explain the positioning, or use the tactic I showed above. Make a new commit, push to origin, and it should show up here.
Pull Request Checklist
This requests fixes issue #74