-
Notifications
You must be signed in to change notification settings - Fork 771
Update README.md - fixed urls #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated all deployment URLs from deployments.mcp-agent-cloud.lastmileai.dev to deployments.mcp-agent.com
WalkthroughUpdated SSE endpoint domains in the example README for Claude Desktop and MCP Inspector integrations, switching from deployments.mcp-agent-cloud.lastmileai.dev to deployments.mcp-agent.com. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/basic/mcp_basic_agent/README.md (1)
148-148
: Keep the endpoint DRY in docs.Minor: consider introducing a single placeholder (e.g., AGENT_SSE_URL) once, then reference it in both the Claude Desktop and Inspector sections to avoid future drift.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/basic/mcp_basic_agent/README.md
(2 hunks)
🔇 Additional comments (1)
examples/basic/mcp_basic_agent/README.md (1)
125-125
: Stale old SSE domain remains — update to deployments.mcp-agent.comFound leftover occurrences of deployments.mcp-agent-cloud.lastmileai.dev; replace them with deployments.mcp-agent.com in these files:
- docs/cloud/agent-server.mdx:185
- docs/cloud/overview.mdx:74, 95
- examples/basic/mcp_model_selector/README.md:101, 124
- examples/mcp_agent_server/asyncio/README.md:225
- examples/usecases/mcp_github_to_slack_agent/README.md:114, 137
- examples/workflows/workflow_evaluator_optimizer/README.md:135, 159
- examples/workflows/workflow_intent_classifier/README.md:87, 110
- examples/workflows/workflow_orchestrator_worker/README.md:105, 128
⛔ Skipped due to learnings
Learnt from: CR PR: lastmile-ai/mcp-agent#0 File: examples/usecases/reliable_conversation/CLAUDE.md:0-0 Timestamp: 2025-07-22T18:59:49.368Z Learning: Applies to examples/usecases/reliable_conversation/examples/reliable_conversation/src/**/*.py : Use mcp-agent's Agent abstraction for ALL LLM interactions, including quality evaluation, to ensure consistent tool access, logging, and error handling.
Updated all deployment URLs from deployments.mcp-agent-cloud.lastmileai.dev to deployments.mcp-agent.com
Summary by CodeRabbit