-
Notifications
You must be signed in to change notification settings - Fork 768
Update README.md - fixed urls #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated deployment URLs from deployments.mcp-agent-cloud.lastmileai.dev to deployments.mcp-agent.com
WalkthroughDocumentation update changing two SSE URL references in examples/workflows/workflow_evaluator_optimizer/README.md from the Lastmile AI cloud domain to the agent.com domain. No code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/workflows/workflow_evaluator_optimizer/README.md
(2 hunks)
🔇 Additional comments (1)
examples/workflows/workflow_evaluator_optimizer/README.md (1)
159-161
: MCP Inspector table updated correctly — no other occurrences found. rg returned only examples/workflows/workflow_evaluator_optimizer/README.md (SSE URL at line 159).
"https://[your-agent-server-id].deployments.mcp-agent.com/sse", | ||
"--header", | ||
"Authorization: Bearer ${BEARER_TOKEN}" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
URL swap looks correct; please verify repo‑wide consistency and endpoint validity.
Change to deployments.mcp-agent.com for the SSE endpoint LGTM. Please confirm there are no remaining references to the old domain and that all SSE examples consistently include the /sse suffix.
Run:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find any lingering old-domain references
rg -n --hidden -S 'deployments\.mcp-agent-cloud\.lastmileai\.dev'
# Spot any new-domain mentions that might be missing the /sse suffix in docs/examples
rg -nP --hidden 'https://\[.*?\]\.deployments\.mcp-agent\.com(?!/sse)\b' examples docs || true
Length of output: 2008
URL swap incomplete — lingering old-domain references found
-
Found matches referencing deployments.mcp-agent-cloud.lastmileai.dev (update to https://[your-agent-server-id].deployments.mcp-agent.com/sse):
examples/usecases/mcp_github_to_slack_agent/README.md:114,137
examples/mcp_agent_server/asyncio/README.md:225
examples/workflows/workflow_orchestrator_worker/README.md:105,128
examples/workflows/workflow_intent_classifier/README.md:87,110
docs/cloud/overview.mdx:74,95
docs/cloud/agent-server.mdx:185
examples/basic/mcp_model_selector/README.md:101,124
examples/basic/mcp_basic_agent/README.md:125,148 -
Your second rg pattern failed with a PCRE2 error; use these commands to finish verification:
- rg -n --hidden -S 'deployments.mcp-agent-cloud.lastmileai.dev'
- rg -n --hidden 'https://[.*].deployments.mcp-agent.com' examples docs | rg -v '/sse' || true
🤖 Prompt for AI Agents
In examples/workflows/workflow_evaluator_optimizer/README.md around lines
135-138, the example still references the old domain; search the repo for any
remaining deployments.mcp-agent-cloud.lastmileai.dev entries and replace them
with the new pattern https://[your-agent-server-id].deployments.mcp-agent.com
(ensure the /sse path is present where appropriate and the Authorization header
line remains unchanged), then verify no other lingering references by running
the suggested ripgrep checks (rg -n --hidden -S
'deployments\.mcp-agent-cloud\.lastmileai\.dev' and rg -n --hidden
'https://\[.*\]\.deployments\.mcp-agent\.com' examples docs | rg -v '/sse' ||
true) and update the listed files accordingly.
Updated deployment URLs from deployments.mcp-agent-cloud.lastmileai.dev to deployments.mcp-agent.com
Summary by CodeRabbit