-
Notifications
You must be signed in to change notification settings - Fork 768
fix: example update secret tagging #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates example configs and code: removes commented secret placeholders in two secrets templates, switches example/model settings from gpt-4.1 to gpt-5 in one workflow, and adds a commented optional temporal deployment block to a workflow config. No control-flow or API surface changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example (1)
19-20
: Add placeholder warning — do not commit real Anthropic API keys.examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example (lines 19–20): anthropic.api_key is consumed by the config loader/tests; replace the plaintext placeholder with a non-secret placeholder and a one-line warning.
anthropic: - api_key: your-anthropic-api-key + # Placeholder only. Do NOT commit real secrets; use env injection or your secrets manager. + api_key: "YOUR_ANTHROPIC_API_KEY"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
examples/usecases/mcp_github_to_slack_agent/mcp_agent.secrets.yaml.example
(1 hunks)examples/workflows/workflow_evaluator_optimizer/main.py
(1 hunks)examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml
(2 hunks)examples/workflows/workflow_evaluator_optimizer/mcp_agent.secrets.yaml.example
(0 hunks)
💤 Files with no reviewable changes (1)
- examples/workflows/workflow_evaluator_optimizer/mcp_agent.secrets.yaml.example
🧰 Additional context used
🧬 Code graph analysis (1)
examples/workflows/workflow_evaluator_optimizer/main.py (1)
src/mcp_agent/workflows/llm/augmented_llm.py (1)
RequestParams
(124-174)
🔇 Additional comments (3)
examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml (2)
39-39
: OpenAI default_model set to "gpt-5" — canonical ID confirmed (gpt-5, verified 2025-09-16); add runtime fallback
- Official model ID: "gpt-5" (OpenAI docs, verified Sep 16, 2025).
- Occurrences: examples/workflows/workflow_evaluator_optimizer/mcp_agent.config.yaml:39; examples/basic/mcp_basic_agent/mcp_agent.config.yaml:24; examples/workflows/workflow_evaluator_optimizer/main.py:81.
- Action: validate model access at startup or catch API errors and fall back to a configurable alternative (e.g., gpt-4.1) to avoid runtime failures.
6-10
: Verified — temporal block supported; default timeout = 60sTemporalSettings exists in the schema (top-level "temporal", $defs.TemporalSettings) with required host and task_queue and timeout_seconds default 60; src/mcp_agent/config.py also defaults timeout_seconds=60. The commented example is fine — if you uncomment it you must supply host and task_queue.
examples/workflows/workflow_evaluator_optimizer/main.py (1)
79-82
: Prefer the configured default model instead of hardcoding "gpt-5"If this example isn't intentionally demonstrating a per-call override, remove the explicit model so RequestParams() inherits the app config default. Per-call overrides are supported across examples/tests, but unable to find evidence in the repo that openai.default_model is set to "gpt-5" — confirm config if you rely on that.
File: examples/workflows/workflow_evaluator_optimizer/main.py:79-82
request_params=RequestParams(model="gpt-5"),
request_params=RequestParams(),
TL;DR
Updated model references from
gpt-4.1
togpt-5
and removed commented-out developer secret references.What changed?
gpt-4.1
togpt-5
in both the config file and the main.py scriptHow to test?
mcp_agent.config.yaml
andmain.py
are correctly updated togpt-5
Why make this change?
This change updates the model references to use the latest GPT model and simplifies the example configuration files by removing unnecessary commented-out developer secret references. The added temporal configuration section provides guidance for users who need to adjust timeout settings for cloud deployments.
Summary by CodeRabbit
New Features
Chores
Documentation