-
Notifications
You must be signed in to change notification settings - Fork 771
'update' CLI command, and also a --noauth flag #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughIntroduces an apps update CLI command, wires it into the cloud CLI, extends API and mock clients with unauthenticatedAccess support and update functionality, updates deploy command to pass/create/update this flag, and adds corresponding tests. Minor logging reformatting included. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI as apps update CLI
participant Resolver as resolve_server
participant Client as MCPAppClient
participant API as Cloud API
User->>CLI: mcp-agent apps update <id|name> [--name ... --desc ... --no-auth/--auth]
CLI->>Resolver: resolve_server(app_id_or_name)
Resolver-->>CLI: MCPApp or MCPAppConfiguration
CLI->>Client: update_app(app_id, name?, description?, unauthenticated_access?)
Client->>API: PATCH /apps/{app_id} { name?, description?, unauthenticatedAccess? }
API-->>Client: Updated MCPApp
Client-->>CLI: MCPApp
CLI-->>User: Print updated summary (id, name, desc, server URL, auth status)
note over CLI,Client: On UnauthenticatedError → raise CLIError
sequenceDiagram
autonumber
actor User
participant Deploy as deploy CLI
participant Client as MCPAppClient
participant API as Cloud API
User->>Deploy: mcp-agent deploy [--no-auth | --auth]
alt App does not exist
Deploy->>Client: create_app(name, desc?, unauthenticated_access?)
Client->>API: POST /apps { name, description?, unauthenticatedAccess? }
API-->>Client: MCPApp
else App exists
Deploy->>Client: update_app(app_id, description?, unauthenticated_access?)
Client->>API: PATCH /apps/{app_id} { description?, unauthenticatedAccess? }
API-->>Client: MCPApp
end
Deploy-->>User: Print post-deploy with auth requirement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
🧰 Additional context used🧬 Code graph analysis (10)src/mcp_agent/cli/cloud/commands/apps/update/__init__.py (3)
src/mcp_agent/cli/cloud/commands/apps/update/main.py (5)
src/mcp_agent/cli/cloud/commands/deploy/wrangler_wrapper.py (1)
tests/cli/commands/test_deploy_command.py (3)
src/mcp_agent/cli/cloud/commands/deploy/main.py (5)
src/mcp_agent/cli/mcp_app/api_client.py (3)
src/mcp_agent/cli/mcp_app/mock_client.py (2)
src/mcp_agent/cli/cloud/main.py (2)
tests/cli/commands/test_apps_update.py (3)
src/mcp_agent/cli/cloud/commands/apps/__init__.py (3)
🔇 Additional comments (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
update
command (mcp-agent cloud apps update
) to toggle auth, name, description, etc.Summary by CodeRabbit
New Features
Style
Tests