Skip to content

Conversation

@jtcorbett
Copy link
Contributor

@jtcorbett jtcorbett commented Oct 23, 2025

Summary by CodeRabbit

  • Chores
    • Updated development environment configuration to optimize file watching.
  • Refactor
    • Streamlined install command registration structure for improved maintainability.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes refactor the CLI command registration system by removing the top-level Typer app from the install command module and updating the main CLI entry point to register the install command as a direct function-based command instead of mounting it as a sub-app. Additionally, a VSCode settings file is configured to exclude target directories from file watching.

Changes

Cohort / File(s) Summary
VSCode Configuration
\.vscode/settings\.json
Added files.watcherExclude setting to ignore all target directories.
Install Command Simplification
src/mcp_agent/cli/commands/install\.py
Removed top-level Typer app initialization and the @app.callback(invoke_without_command=True) decorator; the install function logic remains unchanged.
CLI Command Registration
src/mcp_agent/cli/main\.py
Changed install command registration from app.add_typer(install_cmd.app, ...) to direct function command via app.command(...)(install_cmd.install).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • rholinshead
  • saqadri

Poem

🐰 CLI commands now flow straight and clean,
No nested apps cluttering the scene,
Direct functions light the way,
Simpler wiring, brighter day!
Target folders hide from sight,
All the command paths feel right. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 10-23-fix_command_order_for_install_command

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 127a2be and 583beab.

📒 Files selected for processing (3)
  • .vscode/settings.json (1 hunks)
  • src/mcp_agent/cli/commands/install.py (0 hunks)
  • src/mcp_agent/cli/main.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jtcorbett jtcorbett requested a review from saqadri October 23, 2025 16:40
@jtcorbett jtcorbett force-pushed the 10-23-fix_command_order_for_install_command branch from cea33f6 to f94b6ff Compare October 23, 2025 16:40
@jtcorbett jtcorbett marked this pull request as ready for review October 23, 2025 16:41
@jtcorbett jtcorbett force-pushed the 10-23-fix_command_order_for_install_command branch from f94b6ff to 583beab Compare October 23, 2025 16:41
@jtcorbett jtcorbett merged commit 56dcca5 into main Oct 23, 2025
8 of 9 checks passed
andrew-lastmile pushed a commit to andrew-lastmile/mcp-agent-fork that referenced this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants