Commit 61fea68
committed
fix: correct ESLint fixes to use Zustand getState() pattern
The previous fix created unstable dependencies by using the entire
store state object in useEffect dependencies, causing re-renders
and test timeouts.
Changes:
- app/[locale]/page.tsx: Use useTimerStore.getState().tick() to avoid
tick function dependency issues
- ServiceWorkerRegistration.tsx: Use useNotificationStore.getState()
to avoid setPermission dependency issues
- Remove unused useStore import
This follows Zustand best practices for accessing actions in effects
without creating dependencies on store state.
Verified locally:
- pnpm lint: passes with --max-warnings=0
- pnpm build: successful production build1 parent 6382a5f commit 61fea68
File tree
2 files changed
+7
-11
lines changed- app/[locale]
- components/notifications
2 files changed
+7
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
67 | | - | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
| |||
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
16 | | - | |
17 | | - | |
18 | 15 | | |
19 | | - | |
20 | | - | |
21 | 16 | | |
22 | 17 | | |
23 | 18 | | |
| |||
27 | 22 | | |
28 | 23 | | |
29 | 24 | | |
30 | | - | |
| 25 | + | |
31 | 26 | | |
32 | 27 | | |
33 | 28 | | |
34 | 29 | | |
35 | 30 | | |
36 | 31 | | |
37 | 32 | | |
38 | | - | |
| 33 | + | |
39 | 34 | | |
40 | 35 | | |
41 | 36 | | |
42 | 37 | | |
43 | 38 | | |
44 | 39 | | |
45 | | - | |
| 40 | + | |
46 | 41 | | |
47 | 42 | | |
48 | 43 | | |
| |||
0 commit comments