Skip to content

refactor: decompose KanbanBoard God Component into focused hooks #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryota-murakami merged 6 commits into from
Feb 20, 2026
Merged

refactor: decompose KanbanBoard God Component into focused hooks #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6eedb2a
refactor: seal useRepositorySearch API — replace raw setters with sem…
ryota-murakami Feb 20, 2026
a849be8
refactor: extract useKanbanDnD hook from KanbanBoard (#141, #145)
ryota-murakami Feb 20, 2026
23bdcd9
refactor: extract useKanbanUndo hook from KanbanBoard (#142)
ryota-murakami Feb 20, 2026
d891e6c
refactor: extract useCommentState hook from KanbanBoard (#144)
ryota-murakami Feb 20, 2026
621e14f
fix: address CodeRabbit review — error handling + Z-key modifier guard
ryota-murakami Feb 20, 2026
44f09ac
refactor: replace dynamic import with static for updateStatusListPosi…
ryota-murakami Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/components/Board/AddRepositoryCombobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,17 @@ export const AddRepositoryCombobox = memo(function AddRepositoryCombobox({
// --- Extracted hooks ---
const {
searchQuery,
setSearchQuery,
updateSearch,
deferredSearchQuery,
selectedRepos,
setSelectedRepos,
isAdding,
setIsAdding,
startAdding,
finishAdding,
addError,
setAddError,
setAddingError,
toggleRepoSelection,
removeSelectedRepo,
clearSelection,
} = useRepositorySearch()

const { currentUser, filteredOrganizations, isLoadingOrgs, organizations } =
Expand Down Expand Up @@ -253,8 +254,7 @@ export const AddRepositoryCombobox = memo(function AddRepositoryCombobox({
if (selectedRepos.length === 0) return

try {
setIsAdding(true)
setAddError(null)
startAdding()

// Server Action: Add repositories to board with duplicate detection
const result = await addRepositoriesToBoard(
Expand All @@ -264,7 +264,9 @@ export const AddRepositoryCombobox = memo(function AddRepositoryCombobox({
)

if (!result.success) {
setAddError(result.errors?.join(', ') || 'Failed to add repositories')
setAddingError(
result.errors?.join(', ') || 'Failed to add repositories',
)
return
}

Expand All @@ -287,8 +289,8 @@ export const AddRepositoryCombobox = memo(function AddRepositoryCombobox({
)

// Success: clear selection and close combobox
setSelectedRepos([])
setSearchQuery('')
clearSelection()
updateSearch('')
// Close combobox (supports both controlled and uncontrolled modes)
if (onOpenChange) {
onOpenChange(false)
Expand All @@ -304,11 +306,11 @@ export const AddRepositoryCombobox = memo(function AddRepositoryCombobox({
onQuickNoteFocus()
}, 100)
} catch (err) {
setAddError(
setAddingError(
err instanceof Error ? err.message : 'Error adding repositories',
)
} finally {
setIsAdding(false)
finishAdding()
}
}

Expand Down Expand Up @@ -367,7 +369,7 @@ export const AddRepositoryCombobox = memo(function AddRepositoryCombobox({
ref={searchInputRef}
type="text"
value={searchQuery}
onChange={(e) => setSearchQuery(e.target.value)}
onChange={(e) => updateSearch(e.target.value)}
placeholder="Search repositories..."
className="border-input bg-background text-foreground focus:border-primary focus:ring-primary w-full rounded-md border px-3 py-2 text-sm focus:ring-1 focus:outline-none"
aria-label="Search repositories"
Expand Down
Loading