Skip to content

fix: cache init data #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: cache init data #95

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3ae7e9
fix: cache init data
Aug 8, 2025
0a7971d
fix: cache init data
Aug 8, 2025
452512b
cleanup
Aug 8, 2025
9e3ddd4
fix: rm comment
Aug 8, 2025
34ee768
fix: debug
Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 64 additions & 45 deletions runtime/mount/python_lib/lplots/h5/h5ad/process_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import json
from collections.abc import Awaitable, Callable
from typing import Any

Expand All @@ -19,6 +20,8 @@

alignment_is_running = False

init_data_cache: dict[tuple, dict[str, Any]] = {}


async def process_h5ad_request(
msg: dict[str, Any],
Expand Down Expand Up @@ -84,34 +87,67 @@ async def process_h5ad_request(
if init_obs_key is None and init_var_key is None and len(possible_obs_keys) > 0:
init_obs_key = possible_obs_keys[0]

obsm = None
index = None
recomputed_index = False
filters = None
if init_obsm_key is not None:
filters = msg.get("filters")
obsm, index, recomputed_index = get_obsm(
obj_id, adata, init_obsm_key, filters, max_visualization_cells
)
filters = msg.get("filters")

obs = None
unique_obs = None
nrof_obs = None
counts = None
if init_obs_key is not None and init_obs_key in adata.obs:
obs, (unique_obs, counts), nrof_obs = get_obs(
obj_id, adata, init_obs_key, max_visualization_cells
)
cache_key = (
obj_id,
init_obsm_key,
json.dumps(filters, sort_keys=True),
init_obs_key,
init_var_key,
int(max_visualization_cells),
)

gene_column = None
if (
init_var_key is not None
and init_obs_key is None
and init_var_key in adata.var_names
):
gene_column = get_obs_vector(obj_id, adata, init_var_key)
cached_value = init_data_cache.get(cache_key)

if cached_value is None:
obsm = None
index = None
recomputed_index = False
if init_obsm_key is not None:
obsm, index, recomputed_index = get_obsm(
obj_id, adata, init_obsm_key, filters, max_visualization_cells
)

obs = None
unique_obs = None
nrof_obs = None
counts = None
if init_obs_key is not None and init_obs_key in adata.obs:
obs, (unique_obs, counts), nrof_obs = get_obs(
obj_id, adata, init_obs_key, max_visualization_cells
)

gene_column = None
if (
init_var_key is not None
and init_obs_key is None
and init_var_key in adata.var_names
):
gene_column = get_obs_vector(obj_id, adata, init_var_key)

var_index, var_names = get_var_index(obj_id, adata)

cached_value = {
"init_recomputed_index": recomputed_index,
"init_obsm_values": obsm.tolist() if obsm is not None else None,
"init_obsm_index": index.tolist() if index is not None else None,
"init_obsm_filters": filters,
"init_obs_values": obs.tolist() if obs is not None else None,
"init_obs_unique_values": (
unique_obs.tolist() if unique_obs is not None else None
),
"init_obs_counts": counts.tolist() if counts is not None else None,
"init_obs_nrof_values": nrof_obs,
"init_var_index": var_index.tolist(),
"init_var_names": (var_names.tolist() if var_names is not None else None),
"init_var_values": (
gene_column.tolist() if gene_column is not None else None
),
"init_var_key": init_var_key if init_var_key is not None else None,
}

var_index, var_names = get_var_index(obj_id, adata)
init_data_cache[cache_key] = cached_value

global alignment_is_running

Expand All @@ -134,32 +170,15 @@ async def process_h5ad_request(
# init state with these
"init_obs_key": init_obs_key,
"init_obsm_key": init_obsm_key,
"init_recomputed_index": recomputed_index,
"init_obsm_values": obsm.tolist() if obsm is not None else None,
"init_obsm_index": index.tolist() if index is not None else None,
"init_obsm_filters": filters,
"init_obs_values": obs.tolist() if obs is not None else None,
"init_obs_unique_values": (
unique_obs.tolist() if unique_obs is not None else None
),
"init_obs_counts": counts.tolist() if counts is not None else None,
"init_obs_nrof_values": nrof_obs,
# var info
"init_var_index": var_index.tolist(),
"init_var_names": (
var_names.tolist() if var_names is not None else None
),
# var color by info
"init_var_values": (
gene_column.tolist() if gene_column is not None else None
),
"init_var_key": init_var_key if init_var_key is not None else None,
**cached_value,
# alignment info
"alignment_is_running": alignment_is_running,
# views info
"init_views": adata.uns.get("latch_views", []),
# images
"init_images": adata.uns.get("latch_images", {}),
"cache_key": cache_key,
"was_cached": cached_value is not None,
}
},
}
Expand Down