Do not fail fetches on unknown attributes#306
Conversation
Just ignore the attributes we do not know anythign about. Signed-off-by: Simo Sorce <simo@redhat.com>
Jakuje
left a comment
There was a problem hiding this comment.
code looks good .
For RPM build, we need to bump the toml version. Either bump to 0.9 or just relax the requirements to work with >0.8, <0.10 (preferred).,
Can't support both 0.8 and 0.9, as 0.9 breaks API, so I need to fix more things now ... |
|
then in can be done in separate PR. This is good to go. |
|
it was just a matter of explicitly adding a new feature in Cargo.toml not a real API breakage, so I added it to this PR. |
I think it needs to come also here: https://github.com/latchset/kryoptic/blob/main/.github/workflows/rpm.yml#L58 |
|
The other test looks like the flaky one |
|
@Jakuje Sounds like just upgrading toml does not resolve the RPM issue, so I will drop the commit and leave it to you to investigate |
Signed-off-by: Simo Sorce <simo@redhat.com>
|
Ah I saw the comment about the workfloow just now, lemme see if that fixes it |
|
And it does. Merging. Thanks! |
Description
Just ignore the attributes we do not know anythign about.
This is causing a CKR_DEVICE_ERROR on unknown attributes (like CKA_PAREMETER_SET) instead of just returning they are unknown.
Checklist
Reviewer's checklist: