Ossl: Ensure libctx is freed on drop#312
Merged
simo5 merged 2 commits intolatchset:mainfrom Jul 31, 2025
Merged
Conversation
Signed-off-by: Simo Sorce <simo@redhat.com>
Jakuje
approved these changes
Jul 31, 2025
Contributor
Jakuje
left a comment
There was a problem hiding this comment.
looks straightforward enough
Enables pqc in the build Signed-off-by: Simo Sorce <simo@redhat.com>
Jakuje
approved these changes
Jul 31, 2025
Contributor
Jakuje
left a comment
There was a problem hiding this comment.
still ack. The failed test is the flaky one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As pointed out in #311 we do not free the Context on drop.
When this code was embedded in kryoptic this was not really necessary as Kryoptic uses a single global context in a lazyly initialized static variable.
But now Ossl exposes the ability to create as many as you want, so they need to be freed on drop.
Checklist
Reviewer's checklist: