Update to rust-cryptoki 0.11 #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me, but also looks like the rpm test need to be addressed and the PR rebased on top of the other changes I just merged. |
The API break happened in the following commit 926c43e200e0a98d992edd8db0ead37633be443a Signed-off-by: Jakub Jelen <jjelen@redhat.com>
Contributor
Author
|
Rebased. The RPM test needs to be waived as we will not get rust-cryptoki updated in fedora before we will be able to update kryoptic (in one side tag). We can actually take this PR as a downstream patch before we will have a release, but I wanted to have it upstream and reviewed anyway first. |
Contributor
Author
Thinking further, I think the best would be to pull this to downstream patch, update rust-cryptoki in Fedora and only after that to merge this. Will prepare a downstream PRs fro Fedora. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API break happened in the following commit parallaxsecond/rust-cryptoki@926c43e
Based on the discussion in https://bugzilla.redhat.com/show_bug.cgi?id=2423922 the simplest would be updating the kryoptic to cryptoki 0.11 and then updating rust-cryptoki and kryoptic in Fedora to avoid over-complicating things.
The RPM CI will fail here.
Checklist
- [ ] Test suite updated with functionality tests- [ ] Test suite updated with negative tests- [ ] Rustdoc string were added or updated- [ ] CHANGELOG and/or other documentation added or updated- [ ] This is not a code changeReviewer's checklist: