Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to accelerate OpenSSL builds (particularly for FIPS) by adding parallelization to make jobs and disabling the building of OpenSSL documentation and tests.
Changes:
- Added "no-docs" and "no-tests" flags to OpenSSL configuration to skip building documentation and test programs
- Added parallelization to the make command using the number of available CPU cores
|
@keldonin please fix stile |
|
here you go. Sorry, overlooked that. |
We must rustfmt (see make fix-format). I will recheck why it is producing diverging changes, but I suggest running |
Might be an opportunity for a pre-commit hook. |
|
Oh it is probably because we did not update formatting to edition 2024 ... yeah that will require a flag day, but that flag day is not today :-D |
simo5
left a comment
There was a problem hiding this comment.
Change looks good to me, please rebase on main and squash fixes and I'll merge
Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
1b449aa to
06c12ee
Compare
|
Thank you! |
Description
This PR is implementing a few changes to accelerate build with fips feature. It essentially parallelize make jobs, and strips off documentation and testing of OpenSSL.
Note: I checked "This is not a code change" as it pertains to the build system. depending on the scope you set behind "code change", this might be the case or not.
Checklist
Test suite updated with functionality testsTest suite updated with negative testsRustdoc string were added or updatedCHANGELOG and/or other documentation added or updatedReviewer's checklist: