Skip to content

accelerate FIPS builds#412

Merged
simo5 merged 1 commit intolatchset:mainfrom
keldonin:accelerate_fips_build
Feb 3, 2026
Merged

accelerate FIPS builds#412
simo5 merged 1 commit intolatchset:mainfrom
keldonin:accelerate_fips_build

Conversation

@keldonin
Copy link
Contributor

@keldonin keldonin commented Jan 31, 2026

Description

This PR is implementing a few changes to accelerate build with fips feature. It essentially parallelize make jobs, and strips off documentation and testing of OpenSSL.

Note: I checked "This is not a code change" as it pertains to the build system. depending on the scope you set behind "code change", this might be the case or not.

Checklist

  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Rustdoc string were added or updated
  • CHANGELOG and/or other documentation added or updated
  • This is not a code change

Reviewer's checklist:

  • Any issues marked for closing are fully addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • A changelog entry is added if the change is significant
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible text
  • Doc string are properly updated

Copilot AI review requested due to automatic review settings January 31, 2026 21:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to accelerate OpenSSL builds (particularly for FIPS) by adding parallelization to make jobs and disabling the building of OpenSSL documentation and tests.

Changes:

  • Added "no-docs" and "no-tests" flags to OpenSSL configuration to skip building documentation and test programs
  • Added parallelization to the make command using the number of available CPU cores

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good idea.

@simo5
Copy link
Member

simo5 commented Feb 2, 2026

@keldonin please fix stile

@keldonin
Copy link
Contributor Author

keldonin commented Feb 2, 2026

here you go. Sorry, overlooked that.
BTW, executing cargo fmt on the project produces a lot of changes... Maybe worth a cosmetic commit from your side to fix it all?

@simo5
Copy link
Member

simo5 commented Feb 2, 2026

here you go. Sorry, overlooked that. BTW, executing cargo fmt on the project produces a lot of changes... Maybe worth a cosmetic commit from your side to fix it all?

We must rustfmt (see make fix-format).
I supposed cargo format is not reading the right config file?

I will recheck why it is producing diverging changes, but I suggest running make fix-format on your changes for now.

@keldonin
Copy link
Contributor Author

keldonin commented Feb 2, 2026

I will recheck why it is producing diverging changes, but I suggest running make fix-format on your changes for now.

Might be an opportunity for a pre-commit hook.

@simo5
Copy link
Member

simo5 commented Feb 2, 2026

Oh it is probably because we did not update formatting to edition 2024 ... yeah that will require a flag day, but that flag day is not today :-D

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, please rebase on main and squash fixes and I'll merge

Signed-off-by: Eric Devolder <eric.devolder@gmail.com>
@keldonin keldonin force-pushed the accelerate_fips_build branch from 1b449aa to 06c12ee Compare February 2, 2026 15:26
@simo5 simo5 merged commit 049c05c into latchset:main Feb 3, 2026
85 of 138 checks passed
@simo5
Copy link
Member

simo5 commented Feb 3, 2026

Thank you!

@keldonin keldonin deleted the accelerate_fips_build branch February 3, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants