Use standard CKR_TOKEN_NOT_INITIALIZED error#413
Merged
simo5 merged 1 commit intolatchset:mainfrom Feb 3, 2026
Merged
Conversation
Jakuje
approved these changes
Feb 3, 2026
Contributor
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
code-wise looks good. Not sure whats up with the CI ...
Member
Author
GitHub had a multi-hour incident with Actions yesterday. |
Replace the custom vendor error `KRR_TOKEN_NOT_INITIALIZED` with the standard PKCS#11 error `CKR_TOKEN_NOT_INITIALIZED`. This resolves a FIXME and improves compliance with the PKCS#11 standard by using a standard error code where appropriate. Co-authored-by: Gemini <gemini@google.com> Signed-off-by: Simo Sorce <simo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the custom vendor error
KRR_TOKEN_NOT_INITIALIZEDwith the standard PKCS#11 errorCKR_TOKEN_NOT_INITIALIZED.This resolves a FIXME and improves compliance with the PKCS#11 standard by using a standard error code where appropriate.
Checklist
Reviewer's checklist: