Open
Conversation
simo5
reviewed
Jan 30, 2026
simo5
reviewed
Jan 30, 2026
simo5
approved these changes
Jan 30, 2026
Member
simo5
left a comment
There was a problem hiding this comment.
LGTM,
please squash the fixups and add your sign-off to the commit
Member
|
Covscan servers are down for maintenance, will re-run the scan later, after squash and signoff are applied |
OpenSSL is going to make ASN1_STRING opaque. The accessors in question have been around in OpenSSL for a very long time. (see openssl/openssl#29117)
Member
|
Unfortunately it seems coverity is having some extended maintenance issues, I can waive it off, but the DCO check is required. @bob-beck can you please ass the sign-off-by trailer to your commit ? ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL is going to make ASN1_STRING opaque. The accessors in question have been around in OpenSSL for a very long time.
see openssl/openssl#29117
and specifically openssl/openssl#29862
Description
Checklist
Reviewer's checklist: