Skip to content

Use accessors for ASN1_STRING values#676

Open
bob-beck wants to merge 1 commit intolatchset:mainfrom
bob-beck:main
Open

Use accessors for ASN1_STRING values#676
bob-beck wants to merge 1 commit intolatchset:mainfrom
bob-beck:main

Conversation

@bob-beck
Copy link

@bob-beck bob-beck commented Jan 30, 2026

OpenSSL is going to make ASN1_STRING opaque. The accessors in question have been around in OpenSSL for a very long time.

see openssl/openssl#29117
and specifically openssl/openssl#29862

Description

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

@bob-beck bob-beck marked this pull request as ready for review January 30, 2026 01:05
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there :)

@simo5 simo5 added the covscan Triggers Coverity Scanner label Jan 30, 2026
Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
please squash the fixups and add your sign-off to the commit

@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Jan 30, 2026
@simo5
Copy link
Member

simo5 commented Jan 30, 2026

Covscan servers are down for maintenance, will re-run the scan later, after squash and signoff are applied

Copy link
Author

@bob-beck bob-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OpenSSL is going to make ASN1_STRING opaque. The accessors
in question have been around in OpenSSL for a very long time.

(see openssl/openssl#29117)
@simo5 simo5 added the covscan Triggers Coverity Scanner label Feb 2, 2026
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Feb 2, 2026
@simo5
Copy link
Member

simo5 commented Feb 3, 2026

Unfortunately it seems coverity is having some extended maintenance issues, I can waive it off, but the DCO check is required. @bob-beck can you please ass the sign-off-by trailer to your commit ? (git commit -s --amend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants