Skip to content

docs: add missing docstrings to utility functions#3281

Closed
travellingsoldier85 wants to merge 8 commits intolatent-to:stagingfrom
travellingsoldier85:docs/add-missing-docstrings-utils
Closed

docs: add missing docstrings to utility functions#3281
travellingsoldier85 wants to merge 8 commits intolatent-to:stagingfrom
travellingsoldier85:docs/add-missing-docstrings-utils

Conversation

@travellingsoldier85
Copy link
Copy Markdown

Summary

Add comprehensive Google-style docstrings to 5 public utility functions that were missing documentation.

Changes

  • calculate_fees() in bittensor/utils/liquidity.py
  • ss58_to_vec_u8() in bittensor/utils/__init__.py
  • u16_normalized_float() in bittensor/utils/__init__.py
  • u64_normalized_float() in bittensor/utils/__init__.py
  • get_hash() in bittensor/utils/__init__.py

These functions are part of the public API but lacked documentation. No functional changes — documentation only.

ibraheem-abe and others added 2 commits January 29, 2026 16:19
Add comprehensive Google-style docstrings to public utility functions
that were missing documentation:

- calculate_fees() in utils/liquidity.py
- ss58_to_vec_u8() in utils/__init__.py
- u16_normalized_float() in utils/__init__.py
- u64_normalized_float() in utils/__init__.py
- get_hash() in utils/__init__.py

These functions are part of the public API and lacked documentation,
making it harder for new contributors and users to understand their
purpose and usage.
@thewhaleking thewhaleking requested a review from a team March 16, 2026 17:48
@thewhaleking thewhaleking changed the base branch from master to staging March 16, 2026 17:56
@thewhaleking
Copy link
Copy Markdown
Contributor

thewhaleking commented Mar 18, 2026

@travellingsoldier85 can you just remove the double backticks from the docs, and we should be good to merge?

Side note: Would you mind explaining why you're using my name and email on commits?
image

@travellingsoldier85 travellingsoldier85 force-pushed the docs/add-missing-docstrings-utils branch from 1f7f626 to be25f04 Compare March 18, 2026 13:08
@travellingsoldier85
Copy link
Copy Markdown
Author

Done — replaced all double backticks (...) with single backticks (...) across both files, and removed a stray docker-compose.yml change that shouldn't have been in this PR. Ready for re-review! 🙏

@travellingsoldier85 travellingsoldier85 force-pushed the docs/add-missing-docstrings-utils branch from be25f04 to acbdea5 Compare March 18, 2026 13:08
@travellingsoldier85 travellingsoldier85 force-pushed the docs/add-missing-docstrings-utils branch from acbdea5 to 5da222f Compare March 18, 2026 13:08
@thewhaleking
Copy link
Copy Markdown
Contributor

Sorry @travellingsoldier85 , we actually require all commits for merges to be GPG signed.

@basfroman basfroman closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants