Removes flake8, uses ruff for linter check

.github/workflows/flake8-and-mypy.yml → .github/workflows/mypy.yml

@@ -1,4 +1,4 @@
-name: Flake8 and Mypy - linters check
+name: Mypy check
 permissions:
   contents: read
 
@@ -55,8 +55,5 @@ jobs:
       - name: Sync dev deps
         run: uv sync --extra dev --dev
 
-      - name: Flake8
-        run: uv run flake8 bittensor/ --count
-
       - name: Mypy
         run: uv run mypy --ignore-missing-imports bittensor/

.github/workflows/ruff.yml

@@ -1,4 +1,4 @@
-name: Ruff - formatter check
+name: Ruff - formatter/linter check
 permissions:
   contents: read
 
@@ -8,26 +8,22 @@ on:
 
 jobs:
   ruff:
-    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
-
+    timeout-minutes: 10
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
 
-      - name: Set up Python
-        uses: actions/setup-python@v6
+      - name: Ruff format check
+        uses: astral-sh/ruff-action@v4.0.0
         with:
-          python-version: "3.11"
-
-      - name: Install Ruff in virtual environment
-        run: |
-          python -m venv venv
-          source venv/bin/activate
-          python -m pip install --upgrade pip
-          python -m pip install ruff==0.11.5
+          version: "0.11.5"
+          args: "format --diff"
+          src: "bittensor tests"
 
-      - name: Ruff format check
-        run: |
-          source venv/bin/activate
-          python -m ruff format --diff bittensor
+      - name: Ruff linter check
+        uses: astral-sh/ruff-action@v4.0.0
+        with:
+          version: "0.11.5"
+          args: "check"
+          src: "bittensor"

Makefile

@@ -35,4 +35,4 @@ check: ruff
 	@mypy --ignore-missing-imports bittensor/ --python-version=3.12
 	@mypy --ignore-missing-imports bittensor/ --python-version=3.13
 	@mypy --ignore-missing-imports bittensor/ --python-version=3.14
-	@flake8 bittensor/ --count
+	@python -m ruff check bittensor/

bittensor/__init__.py

@@ -1,3 +1,7 @@
-from .core.settings import __version__, DEFAULTS, DEFAULT_NETWORK
-from .utils.btlogging import logging
-from .utils.easy_imports import *
+from .core.settings import (
+    __version__ as __version__,
+    DEFAULTS as DEFAULTS,
+    DEFAULT_NETWORK as DEFAULT_NETWORK,
+)
+from .utils.btlogging import logging  #  noqa: F401
+from .utils.easy_imports import *  #  noqa: F403

bittensor/core/extrinsics/asyncex/registration.py

@@ -341,7 +341,7 @@ async def register_extrinsic(
                 if not torch.cuda.is_available():
                     return ExtrinsicResponse(False, "CUDA not available.").with_log()
 
-                logging.debug(f"Creating a POW with CUDA.")
+                logging.debug("Creating a POW with CUDA.")
                 pow_result = await create_pow_async(
                     subtensor=subtensor,
                     wallet=wallet,
@@ -355,7 +355,7 @@ async def register_extrinsic(
                     log_verbose=log_verbose,
                 )
             else:
-                logging.debug(f"Creating a POW.")
+                logging.debug("Creating a POW.")
                 pow_result = await create_pow_async(
                     subtensor=subtensor,
                     wallet=wallet,

bittensor/core/extrinsics/registration.py

@@ -333,7 +333,7 @@ def register_extrinsic(
                 if not torch.cuda.is_available():
                     return ExtrinsicResponse(False, "CUDA not available.").with_log()
 
-                logging.debug(f"Creating a POW with CUDA.")
+                logging.debug("Creating a POW with CUDA.")
                 pow_result = create_pow(
                     subtensor=subtensor,
                     wallet=wallet,
@@ -347,7 +347,7 @@ def register_extrinsic(
                     log_verbose=log_verbose,
                 )
             else:
-                logging.debug(f"Creating a POW.")
+                logging.debug("Creating a POW.")
                 pow_result = create_pow(
                     subtensor=subtensor,
                     wallet=wallet,

bittensor/core/extrinsics/utils.py

@@ -217,11 +217,11 @@ def apply_pure_proxy_data(
     # If triggered events are not available or event PureCreated does not exist in the response, return the response
     # with warning message ot raise the error if raise_error is True.
     message = (
-        f"The ExtrinsicResponse doesn't contain pure_proxy data (`pure_account`, `spawner`, `proxy_type`, etc.) "
-        f"because the extrinsic receipt doesn't have triggered events. This typically happens when "
-        f"`wait_for_inclusion=False` or when `block_hash` is not available. To get this data, either pass "
-        f"`wait_for_inclusion=True` when calling this function, or retrieve the data manually from the blockchain "
-        f"using the extrinsic hash."
+        "The ExtrinsicResponse doesn't contain pure_proxy data (`pure_account`, `spawner`, `proxy_type`, etc.) "
+        "because the extrinsic receipt doesn't have triggered events. This typically happens when "
+        "`wait_for_inclusion=False` or when `block_hash` is not available. To get this data, either pass "
+        "`wait_for_inclusion=True` when calling this function, or retrieve the data manually from the blockchain "
+        "using the extrinsic hash."
     )
     if response.extrinsic is not None and hasattr(response.extrinsic, "extrinsic_hash"):
         extrinsic_hash = response.extrinsic.extrinsic_hash

bittensor/core/metagraph.py

@@ -320,7 +320,7 @@ def S(self) -> Tensor:
         return self.stake
 
     @property
-    def I(self) -> Tensor:
+    def I(self) -> Tensor:  #  noqa: E743
         """
         Incentive values of neurons represent the rewards they receive for their contributions to the network.
         The Bittensor network employs an incentive mechanism that rewards neurons based on their

bittensor/extras/dev_framework/__init__.py

@@ -1,8 +1,8 @@
-from .calls import *  # noqa: F401
+from .calls import *  #  noqa:  F403
 from .subnet import (
-    NETUID,
-    TestSubnet,
-    ACTIVATE_SUBNET,
-    REGISTER_SUBNET,
-    REGISTER_NEURON,
+    NETUID as NETUID,
+    TestSubnet as TestSubnet,
+    ACTIVATE_SUBNET as ACTIVATE_SUBNET,
+    REGISTER_SUBNET as REGISTER_SUBNET,
+    REGISTER_NEURON as REGISTER_NEURON,
 )

bittensor/extras/dev_framework/calls/__init__.py

@@ -11,9 +11,9 @@
 
 import os
 from bittensor import Subtensor
-from bittensor.extras.dev_framework.calls.sudo_calls import *  # noqa: F401
-from bittensor.extras.dev_framework.calls.non_sudo_calls import *  # noqa: F401
-from bittensor.extras.dev_framework.calls.pallets import *  # noqa: F401
+from bittensor.extras.dev_framework.calls.sudo_calls import *  #  noqa: F403
+from bittensor.extras.dev_framework.calls.non_sudo_calls import *  #  noqa: F403
+from bittensor.extras.dev_framework.calls.pallets import *  #  noqa: F403
 
 HEADER = '''"""
 This file is auto-generated. Do not edit manually.

bittensor/extras/dev_framework/subnet.py

@@ -10,7 +10,7 @@
 from bittensor.core.types import ExtrinsicResponse
 from bittensor.extras import SubtensorApi
 from bittensor.utils.btlogging import logging
-from .calls import *  # noqa: F401#
+from .calls import *  #  noqa: F403
 from .utils import (
     is_instance_namedtuple,
     split_command,

bittensor/utils/__init__.py

@@ -28,7 +28,6 @@
 if TYPE_CHECKING:
     from bittensor_wallet import Wallet
     from bittensor.core.types import ExtrinsicResponse
-    from bittensor.utils.balance import Balance
 
 # keep save from import analyzer as obvious aliases
 hex_to_ss58 = ss58_encode

bittensor/utils/btlogging/defines.py

@@ -2,7 +2,7 @@
 
 BASE_LOG_FORMAT = "%(asctime)s | %(levelname)s | %(message)s"
 TRACE_LOG_FORMAT = (
-    f"%(asctime)s | %(levelname)s | %(name)s:%(filename)s:%(lineno)s | %(message)s"
+    "%(asctime)s | %(levelname)s | %(name)s:%(filename)s:%(lineno)s | %(message)s"
 )
 DATE_FORMAT = "%Y-%m-%d %H:%M:%S"
 BITTENSOR_LOGGER_NAME = "bittensor"

bittensor/utils/mock/__init__.py

@@ -1 +1 @@
-from .subtensor_mock import MockSubtensor
+from .subtensor_mock import MockSubtensor as MockSubtensor

bittensor/utils/mock/subtensor_mock.py

@@ -871,9 +871,6 @@ def _neuron_subnet_exists(
         dividends = self._get_most_recent_storage(
             subtensor_state["Dividends"][netuid][uid], block
         )
-        pruning_score = self._get_most_recent_storage(
-            subtensor_state["PruningScores"][netuid][uid], block
-        )
         last_update = self._get_most_recent_storage(
             subtensor_state["LastUpdate"][netuid][uid], block
         )

bittensor/utils/version.py

@@ -117,6 +117,6 @@ def check_latest_version_in_pypi():
         except InvalidVersion:
             # stay silent if InvalidVersion
             pass
-    except (requests.RequestException, KeyError) as e:
+    except (requests.RequestException, KeyError):
         # stay silent if not internet connection or pypi.org issue
         pass

pyproject.toml

@@ -8,7 +8,7 @@ version = "10.2.0"
 description = "Bittensor SDK"
 readme = "README.md"
 authors = [
-    {name = "bittensor.com"}
+    { name = "bittensor.com" }
 ]
 license = { file = "LICENSE" }
 requires-python = ">=3.10,<3.15"
@@ -48,7 +48,6 @@ dev = [
     "pytest-cov==4.0.0",
     "ddt==1.6.0",
     "hypothesis==6.81.1",
-    "flake8==7.0.0",
     "mypy==1.8.0",
     "types-retry==0.9.9.4",
     "typing_extensions>= 4.0.0; python_version<'3.11'",
@@ -94,5 +93,11 @@ classifiers = [
 ]
 
 [tool.setuptools]
-package-dir = {"bittensor" = "bittensor"}
+package-dir = { "bittensor" = "bittensor" }
 script-files = ["bittensor/utils/certifi.sh"]
+
+[tool.ruff]
+exclude = [".git", "__pycache__", "__init__.py", "docs/source/conf.py", "old", "build", "dist", "venv", ".venv", ".tox"]
+
+[tool.ruff.lint]
+select = ["E9", "F63", "F7", "F82", "F401"]

tests/consistency/test_proxy_types.py

@@ -1,5 +1,4 @@
 from bittensor.core.chain_data.proxy import ProxyType
-from bittensor.core.extrinsics.pallets import SubtensorModule, Proxy, Balances
 
 
 def get_proxy_type_fields(meta):

tests/e2e_tests/test_crowdloan.py

@@ -1,6 +1,5 @@
 from bittensor import Balance
 from bittensor.core.extrinsics.pallets import SubtensorModule
-from bittensor_wallet import Wallet
 import pytest
 import asyncio
 

tests/e2e_tests/test_delegate.py

@@ -2,7 +2,6 @@
 
 from bittensor.core.chain_data.chain_identity import ChainIdentity
 from bittensor.core.chain_data.delegate_info import DelegatedInfo, DelegateInfo
-from bittensor.core.chain_data.proposal_vote_data import ProposalVoteData
 from bittensor.core.errors import (
     DelegateTakeTooHigh,
     DelegateTxRateLimitExceeded,
@@ -11,13 +10,9 @@
 )
 from bittensor.utils.balance import Balance
 from tests.e2e_tests.utils import (
-    async_propose,
     async_set_identity,
-    async_vote,
     get_dynamic_balance,
-    propose,
     set_identity,
-    vote,
     TestSubnet,
     AdminUtils,
     ACTIVATE_SUBNET,
@@ -26,7 +21,6 @@
     SUDO_SET_NOMINATOR_MIN_REQUIRED_STAKE,
     SUDO_SET_TX_DELEGATE_TAKE_RATE_LIMIT,
 )
-from tests.helpers.helpers import CloseInValue
 
 DEFAULT_DELEGATE_TAKE = 0.179995422293431
 

tests/e2e_tests/test_incentive.py

@@ -3,7 +3,6 @@
 import pytest
 
 from bittensor.utils.balance import Balance
-from bittensor.utils.btlogging import logging
 from tests.e2e_tests.utils import (
     TestSubnet,
     AdminUtils,

tests/e2e_tests/test_metagraph.py

@@ -14,7 +14,6 @@
 from bittensor.utils.balance import Balance
 from bittensor.utils.btlogging import logging
 from bittensor.utils.registration.pow import LazyLoadedTorch
-from bittensor.utils.weight_utils import convert_and_normalize_weights_and_uids
 from tests.e2e_tests.utils import (
     AdminUtils,
     NETUID,

tests/e2e_tests/test_subnets.py

@@ -1,5 +1,4 @@
 import pytest
-from bittensor.utils.btlogging import logging
 
 
 def test_subnets(subtensor, alice_wallet):

tests/e2e_tests/test_transfer.py

@@ -4,10 +4,9 @@
 import pytest
 
 from bittensor.utils.balance import Balance
-from bittensor import logging
 
 if typing.TYPE_CHECKING:
-    from bittensor.extras import SubtensorApi
+    pass
 
 
 def test_transfer(subtensor, alice_wallet):

tests/e2e_tests/utils/e2e_test_utils.py

@@ -6,7 +6,6 @@
 from typing import Optional
 from bittensor_wallet import Keypair, Wallet
 
-from bittensor.extras import SubtensorApi
 from bittensor.utils.btlogging import logging
 
 template_path = os.getcwd() + "/neurons/"

tests/unit_tests/extrinsics/asyncex/test_coldkey_swap.py

@@ -1,10 +1,7 @@
 import pytest
 from bittensor_wallet import Wallet
-from scalecodec.types import GenericCall
 
 from bittensor.core.extrinsics.asyncex import coldkey_swap
-from bittensor.core.extrinsics.pallets import SubtensorModule
-from bittensor.core.settings import DEFAULT_MEV_PROTECTION
 from bittensor.core.types import ExtrinsicResponse
 from bittensor.core.chain_data.coldkey_swap import ColdkeySwapAnnouncementInfo
 

tests/unit_tests/extrinsics/asyncex/test_weights.py

@@ -1,7 +1,6 @@
 import pytest
 
 from bittensor.core.extrinsics.asyncex import weights as weights_module
-from bittensor.core.settings import version_as_int
 from bittensor.core.types import ExtrinsicResponse
 
 

tests/unit_tests/extrinsics/test_mev_shield.py

@@ -1,4 +1,3 @@
-from bittensor_wallet import Wallet
 from scalecodec.types import GenericCall
 from async_substrate_interface import ExtrinsicReceipt
 from async_substrate_interface.errors import SubstrateRequestException

tests/unit_tests/extrinsics/test_transfer.py

@@ -1,4 +1,3 @@
-import pytest
 from bittensor.core.extrinsics import transfer
 from bittensor.core.settings import DEFAULT_MEV_PROTECTION
 from bittensor.utils.balance import Balance

tests/unit_tests/test_stream.py

@@ -5,9 +5,7 @@
 """
 
 import pytest
-from abc import ABC
-from typing import Optional
-from unittest.mock import AsyncMock, Mock, MagicMock, patch
+from unittest.mock import AsyncMock, Mock
 from aiohttp import ClientResponse
 from starlette.types import Send, Receive, Scope