Update visit_beamer_frame() frame title logic - #1580
Merged
pfoerster merged 2 commits intoJul 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
visit_beamer_frame(...)early returnsNoneif no\frametitlecommand is found in the environment.This PR updates
visit_beamer_frame(...)to handle cases when there is an optional title argument e.g.\begin{frame}{title}or when no title is specified. A\frametitlecommand takes precedence here (as it does in latex). The optional environment argument is the fallback if no\frametitleis found, and if neither are present an untitledFramesymbol is still returned. The function has no path that can returnNone, but I have left the return type as anOptionto match the pattern used at the call site. A helper function for extracting the title and a test to exercise the symbol name logic are provided.resolves #1525