Skip to content

Update visit_beamer_frame() frame title logic - #1580

Merged
pfoerster merged 2 commits into
latex-lsp:masterfrom
nolanking90:fix/1525-beamer-frame-symbols
Jul 4, 2026
Merged

Update visit_beamer_frame() frame title logic#1580
pfoerster merged 2 commits into
latex-lsp:masterfrom
nolanking90:fix/1525-beamer-frame-symbols

Conversation

@nolanking90

Copy link
Copy Markdown
Contributor

Currently visit_beamer_frame(...) early returns None if no \frametitle command is found in the environment.

This PR updates visit_beamer_frame(...) to handle cases when there is an optional title argument e.g. \begin{frame}{title} or when no title is specified. A \frametitle command takes precedence here (as it does in latex). The optional environment argument is the fallback if no \frametitle is found, and if neither are present an untitled Frame symbol is still returned. The function has no path that can return None, but I have left the return type as an Option to match the pattern used at the call site. A helper function for extracting the title and a test to exercise the symbol name logic are provided.

resolves #1525

@pfoerster pfoerster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@pfoerster
pfoerster merged commit 2809f5e into latex-lsp:master Jul 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beamer frame still not listed in symbols

2 participants