Skip to content

Conversation

@geclos
Copy link
Collaborator

@geclos geclos commented Dec 16, 2025

Summary

This PR filters out inactive issues from candidates.

Changes

  • Added method to :

    • Accepts parameter (active/inactive) for flexibility
    • Returns issues filtered by project, document UUID, and status
  • Added helper method:

    • Builds appropriate SQL conditions based on status
    • Handles both active and inactive statuses
  • **Updated **:

    • Now uses the new generic method with
    • More maintainable and reusable approach
  • Cleaned up unused imports in

Testing

All existing tests pass, including the test that verifies inactive candidates are filtered out from discovery results.

@geclos geclos changed the title feat: add generic method to fetch issues by project, document and status feat: filter out inactive issues from candidates pool Dec 16, 2025
@geclos geclos force-pushed the fix/filter_out_inactive_issues_from_candidates branch 4 times, most recently from a2a307f to 2c4c3af Compare December 16, 2025 12:48
andresgutgon
andresgutgon previously approved these changes Dec 19, 2025
@geclos geclos force-pushed the fix/filter_out_inactive_issues_from_candidates branch from 2c4c3af to 531e7ff Compare December 19, 2025 11:15
- Add findByProjectDocumentAndStatus method to IssuesRepository
- Method accepts IssueStatus parameter (active/inactive) for flexibility
- Implement buildStatusCondition helper to build SQL conditions based on status
- Update filterOutInactiveCandidates to use the new generic method
- Remove unused imports from discover.ts
@geclos geclos force-pushed the fix/filter_out_inactive_issues_from_candidates branch from 531e7ff to 15571e1 Compare December 19, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants