User based onboarding #2070
Open
User based onboarding #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csansoon
force-pushed
the
user-based-onboarding
branch
2 times, most recently
from
d3284b9 to
9bfc4d8
Compare
| const [selectedFramework, setSelectedFramework] = | ||
| useState<FrameworkDefinition | null>(null) | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
Why not reuse the PageTrackingWrapper component we use in the other onboarding instead of this useEffect?
learningbizz
previously approved these changes
Dec 31, 2025
csansoon
force-pushed
the
user-based-onboarding
branch
2 times, most recently
from
71ff099 to
acc7cda
Compare
csansoon
force-pushed
the
user-based-onboarding
branch
from
acc7cda to
545320c
Compare
andresgutgon
reviewed
Jan 2, 2026
| ALTER TABLE "latitude"."document_logs" ALTER COLUMN "source" SET DATA TYPE "latitude"."log_source" USING "source"::"latitude"."log_source";--> statement-breakpoint | ||
| ALTER TABLE "latitude"."provider_logs" ALTER COLUMN "source" SET DATA TYPE "latitude"."log_source" USING "source"::"latitude"."log_source";--> statement-breakpoint | ||
| ALTER TABLE "latitude"."evaluation_results" ALTER COLUMN "source" SET DATA TYPE "latitude"."log_source" USING "source"::"latitude"."log_source";--> statement-breakpoint | ||
|
|
Contributor
There was a problem hiding this comment.
andresgutgon
reviewed
Jan 2, 2026
|
|
||
| // Should be Feb 28, 2025 | ||
| expect(result).toEqual(new Date(2025, 1, 28)) | ||
| }) |
Contributor
There was a problem hiding this comment.
Why these tests are removed? How are related?
andresgutgon
reviewed
Jan 2, 2026
| const lastDayOfMonth = new Date(adjustedYear, adjustedMonth + 1, 0).getDate() | ||
| const clampedDay = Math.min(renewalDay, lastDayOfMonth) | ||
|
|
||
| return new Date(adjustedYear, adjustedMonth, clampedDay) |
Contributor
There was a problem hiding this comment.
Oh is related with this but looks unrelated to onboarding
andresgutgon
requested changes
Jan 2, 2026
Contributor
andresgutgon
left a comment
andresgutgon
left a comment
There was a problem hiding this comment.
Review cursed enum migration and 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the Onboarding completion tracking from Workspace to User. Now, every new user will go through the Onboarding! Independently of Workspace.