Filter issues from deleted documents in issues dashboard #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
fix/filter-issues-from-deleted-documents
branch
from
8cc28e2 to
0dcdcd0
Compare
neoxelox
reviewed
Jan 7, 2026
| return Result.ok(true) | ||
| }, | ||
| () => { | ||
| publisher.publishLater({ |
Contributor
There was a problem hiding this comment.
The github diff is distraous, i guess the only thing you have changed is sending this new event?
neoxelox
reviewed
Jan 7, 2026
| if (activeDocumentUuids.length > 0) { | ||
| conditions.push(inArray(issues.documentUuid, activeDocumentUuids)) | ||
| } else { | ||
| conditions.push(sql`FALSE`) |
Contributor
There was a problem hiding this comment.
Ah, you want to return an empty list of issues because there are no active documents in the commit... maybe you should do an early return in the calling function no? so no db hit at all
Contributor
Author
There was a problem hiding this comment.
This else won't happen rarely. All commits should have an active document
neoxelox
approved these changes
Jan 7, 2026
Issues from deleted documents in current commit should not be visible in the issues dashboard.
andresgutgon
force-pushed
the
fix/filter-issues-from-deleted-documents
branch
from
0dcdcd0 to
e800c51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Issues from deleted documents in current commit should not be visible in the issues dashboard.
TODO