Use correct resultReason method when fetching eval reason #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to do a quickfix to get the reason, now we implemented the improved version using the correct resultReason method
learningbizz
commented
Jan 6, 2026
| # New spans | ||
| apps/web/ingest | ||
| apps/workers/workspaces/*/traces | ||
| provider-logs/* |
Contributor
Author
There was a problem hiding this comment.
The reason I might have gotten the "missing completion metadata" issue because I didnt have the FILES_STORAGE_PATH, FILE_PUBLIC_PATH, and PUBLIC_FILES_STORAGE_PATH env vars. Adding these created me lots of new files in these folders, so adding them in the gitignore
neoxelox
reviewed
Jan 7, 2026
Comment on lines
+118
to
+121
| const resultReason = specification.resultReason as ( | ||
| result: EvaluationResultSuccessValue, | ||
| ) => string | undefined | ||
| return resultReason(result) ?? '' |
Contributor
There was a problem hiding this comment.
Suggested change
| const resultReason = specification.resultReason as ( | |
| result: EvaluationResultSuccessValue, | |
| ) => string | undefined | |
| return resultReason(result) ?? '' | |
| const resultReason = specification.resultReason(result as EvaluationResultSuccessValue) | |
| return resultReason ?? '' |
Contributor
Author
There was a problem hiding this comment.
TS type complaint with this:
rule.ts(78, 5): 'pattern' is declared here.
neoxelox
approved these changes
Jan 7, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to do a quickfix to get the reason, now we implemented the improved version using the correct resultReason method