Simplify default composite evaluation management#2093
Merged
andresgutgon merged 1 commit intomainfrom Jan 8, 2026
Merged
Conversation
e5d3968 to
3a14a6b
Compare
Contributor
Author
|
@copilot review the PR and let me know if I'm missing something. Do not open another PR or make changes to this one. Just comment if you see something wrong. Otherwise congratulate me for the great work I did |
Contributor
|
@andresgutgon I've opened a new pull request, #2094, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
Author
|
Eres muy tonto |
neoxelox
reviewed
Jan 8, 2026
.../[documentUuid]/(withTabs)/optimizations/_components/OptimizationForm/EvaluationSelector.tsx
Outdated
Show resolved
Hide resolved
neoxelox
reviewed
Jan 8, 2026
| } | ||
|
|
||
| const validating = await validateSubEvaluations({ uuid, configuration, evaluations }) // prettier-ignore | ||
| const validating = await validateSubEvaluations({ |
Contributor
Author
neoxelox
reviewed
Jan 8, 2026
neoxelox
reviewed
Jan 8, 2026
neoxelox
reviewed
Jan 8, 2026
neoxelox
reviewed
Jan 8, 2026
neoxelox
requested changes
Jan 8, 2026
Contributor
neoxelox
left a comment
There was a problem hiding this comment.
The document cannot be updated with a simple sql query!
3a14a6b to
6fa1861
Compare
neoxelox
previously approved these changes
Jan 8, 2026
1acc921 to
6647691
Compare
Now the system is allowing to have a default composite evaluation of any type. We're changing that here to always have one composite evaluation of type `average`. This way with this we simplify the UI and we don't need all the alerts and toast system to notify when this composite evaluation goes out of sync when a evaluation is removed from an issue for example.
6647691 to
4d809a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What?
Now documents always have one composite evaluation of type
average. This way, we simplify the UI, and we don't need all the alerts and toast system to notify when this composite evaluation goes out of sync.TODO
mainEvaluationUuidin my dev db.defaultTargetis not used in the evals tabledefaultTargetis not used in Composite Form issues selectorsync-compositeare goneDefault composite evaluation lifecycle
averageis created by Latitude in the documentdocument.mainEvaluationUuidnull->mainEvaluationUuidin the documentFrom
defaultTargettomainEvaluationUuidBefore we had
defaultTargetas part of the jsonb config of the composite evalution. Now we do a real link from this evaluation to the document.Also we don't allow users to chose what of the composite evaluations they have in the document is the one that is the default. The default is manage by us. The constrain here is that is always of type
average. The other types likeweighteddemands manual intervention. We let users manage their own evaluations but this one is auto updated and for that we're removing all theAlertsandToastwe had to let users know the main evaluation was out of sync. Makes UI and understanding more complicated