fix: add asChild to Tooltip components wrapping Button triggers#2315
Merged
fix: add asChild to Tooltip components wrapping Button triggers#2315
Conversation
TooltipTrigger renders its own <button> element by default. When a Button component is passed as the trigger, this creates nested <button> elements which is invalid HTML and causes hydration errors. Adding asChild makes the TooltipTrigger merge its props into the child element instead of wrapping it in an additional button. https://claude.ai/code/session_01EsKrmtqHDcdzBA5wifn2d7
andresgutgon
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TooltipTrigger renders its own element by default. When a Button component is passed as the trigger, this creates nested elements which is invalid HTML and causes hydration errors.
Adding asChild makes the TooltipTrigger merge its props into the child element instead of wrapping it in an additional button.
https://claude.ai/code/session_01EsKrmtqHDcdzBA5wifn2d7