fix: handle deleted project gracefully in span ingestion worker#2316
Closed
fix: handle deleted project gracefully in span ingestion worker#2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The error
NotFoundError: Project not foundoccurs inCommitsRepository.getCommitByUuidduring theingestSpansJobBullMQ job. This happens when span telemetry references a project that has been deleted, but the ingestion job still tries to process it.Solution
Added a check after calling
commitsRepo.getCommitByUuid()to verify if the result is OK before proceeding. If the result is an error (project not found), the function now returns early gracefully instead of throwing aNotFoundError.Changes
processfunction: Addedif (!Result.isOk(commitResult)) return commitResultcheck before calling.unwrap()This follows the pattern used elsewhere in the codebase (e.g.,
getResolvedDatafunction).