-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: Fix warnings for custom postgres_## cfg flags #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3d250e0
to
40c749e
Compare
c605bd5
to
2d1a5b1
Compare
The CI failure is a transient database connection error:
I do not see a way to rerun the failed job. |
2d1a5b1
to
a290bbd
Compare
Resigned last commit and forced push to rerun jobs. |
Same transient failure as before, on same
|
a290bbd
to
406ac19
Compare
It could be a race condition with Postgres starting up. I think we normally sleep a certain amount of time to make sure it's up first. |
Same failure, different postgres 13 job. |
I found two more places where the old cfg flags needed to get removed (docs). |
14e844f
to
35abdc6
Compare
Signed-off-by: Joshua Potts <[email protected]>
Signed-off-by: Joshua Potts <[email protected]>
…cstrings) Signed-off-by: Joshua Potts <[email protected]>
4f20b96
to
6a90586
Compare
This error from the step near the end that does |
e4e19e6
to
a92236f
Compare
@abonander the ultimate cause of the failure was a bind failure when docker was trying to use host port 5432 for the job step that stopped the non-ssl container and created the ssl container. Job step with failure: sqlx/.github/workflows/sqlx.yml Lines 305 to 310 in 5f8fc6b
I've amended this pr to split the postgres job into two. That change could be a standalone pr if you wish. |
Signed-off-by: Joshua Potts <[email protected]>
a92236f
to
85d898b
Compare
@abonander I'm done with my flurry of branch updates used to test CI changes. I also cherry picked the last commit which is the fix into its own PR if you prefer that: #3977. |
Resolves build warnings related to custom
cfg
conditions that are present in the code because they are set for various CI runs defined in a matrix in the GitHub workflow.Example warning that disappears with this change:
This changes the
postgres
cfg conditions to be similar to howcfg
conditions are setup formariadb
- version is a value of thepostgres
cfg parameter rather than having a separate parameter/condition for each postgres version.Additional changes
Since Postgres 12 and prior are now EOL and CI was already adjusted In December to exclude Postgres 12 and earlier after Postgres 12 went EOL in November, some code comments and docstrings are adjusted to reflect that.
Docker compose file -
version: 3
was removed since the version field has been deprecated for some time and generates a warning.Github workflow:
docker compose rm -f
did not help either)#3879 will need modification after this is merged.
Does your PR solve an issue?
--cfg
flags.Is this a breaking change?
No - informs linter of an expected set of possible custom
cfg
parameter values, and adjusts test code, but not production code (other than comments)