Skip to content

sqlx-postgres(tests): cleanup 2 unit tests. #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2025
Merged

sqlx-postgres(tests): cleanup 2 unit tests. #4002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70b4ca3
sqlx-postgres(tests): fix positive_int domain type
joeydewaal Aug 26, 2025
f051a7a
sqlx-postgres(tests): Update no pg array test
joeydewaal Aug 26, 2025
7b4d8af
sqlx-core: Remove conflicting Type impl for Box<JsonRawValue>
joeydewaal Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions sqlx-core/src/types/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,20 +196,6 @@ where
}
}

impl<DB> Type<DB> for Box<JsonRawValue>
where
for<'a> Json<&'a Self>: Type<DB>,
DB: Database,
{
fn type_info() -> DB::TypeInfo {
<Json<&Self> as Type<DB>>::type_info()
}

fn compatible(ty: &DB::TypeInfo) -> bool {
<Json<&Self> as Type<DB>>::compatible(ty)
}
}

impl<'q, DB> Encode<'q, DB> for JsonRawValue
where
for<'a> Json<&'a Self>: Encode<'q, DB>,
Expand Down
2 changes: 1 addition & 1 deletion tests/postgres/derives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ async fn test_custom_pg_array() -> anyhow::Result<()> {

impl PgHasArrayType for User {
fn array_type_info() -> sqlx::postgres::PgTypeInfo {
sqlx::postgres::PgTypeInfo::array_of("Gebruiker")
sqlx::postgres::PgTypeInfo::array_of("User")
}
}
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion tests/postgres/setup.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ CREATE TABLE circles (
EXCLUDE USING gist (c WITH &&)
);

CREATE DOMAIN positive_int AS integer CHECK (VALUE >= 0);
CREATE DOMAIN positive_int AS integer CHECK (VALUE > 0);
CREATE DOMAIN percentage AS positive_int CHECK (VALUE <= 100);

CREATE TYPE person as (
Expand Down
Loading