feat: Add KMS key ID output and enhance log group tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-vaughan-nttd
commented
Nov 24, 2025
ben-vaughan-nttd
commented
- Added new github workflows.
- Added output for KMS key ID in outputs.tf.
- Updated TestLogGroup in test_impl.go to include KMS key ID validation.
- Implemented retry logic for DescribeLogGroups to handle eventual consistency.
- Modified GetAWSConfig to accept region as a parameter and extract it from ARN.
- Updated required Terraform version in versions.tf to allow for minor updates.
- Added new github workflows. - Added output for KMS key ID in outputs.tf. - Updated TestLogGroup in test_impl.go to include KMS key ID validation. - Implemented retry logic for DescribeLogGroups to handle eventual consistency. - Modified GetAWSConfig to accept region as a parameter and extract it from ARN. - Updated required Terraform version in versions.tf to allow for minor updates.
|
Caution Auto-labeling failed, likely due to a misconfiguration in the The auto-labeler workflow was allowed to complete successfully because you have a configuration change to Please manually apply the appropriate label ( |
aarti-joshi-nttd
requested changes
Nov 25, 2025
|
|
||
| } | ||
|
|
||
| resource "aws_kms_key_policy" "cloudwatch_logs" { |
There was a problem hiding this comment.
We could use primitive https://github.com/launchbynttdata/tf-aws-module_primitive-kms_key_policy instead of resource
| # regal ignore:FG_R00068 | ||
| source = "../.." | ||
|
|
||
| name = var.name |
There was a problem hiding this comment.
could use resource naming module for creation of name of the resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.