Refactor EFS outputs to enhance idempotency #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, Terraform checks, and release publishing
- Added new outputs to outputs.tf for EFS file system attributes including availability zone ID, name, and size. - Created a comprehensive test suite using Terratest for the EFS module, including full lifecycle and read-only tests. - Implemented detailed README files for tests, outlining structure, usage, and best practices. - Developed shared test implementation logic in testimpl package, providing reusable functions and AWS SDK integration. - Updated variables.tf to include new configuration options for EFS, such as name, availability zone, lifecycle policies, and protection settings.
…for standardized naming
…d names and correct tflint.hcl file in root
…clarity and consistency
… remove obsolete files
- Removed outputs for availability_zone_id, availability_zone_name, number_of_mount_targets, owner_id, and size_in_bytes to prevent idempotency issues in parent modules. - Added comments to clarify the rationale behind exposing only static outputs.
…policy documentation
Signed-off-by: jaxom-widby-nttd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dynamic values from EFS outputs to prevent idempotency issues in parent modules and add comments for clarity on the rationale behind exposing only static outputs.