-
Notifications
You must be signed in to change notification settings - Fork 30
Added some missing options #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GastonZalba
wants to merge
10
commits into
launchcodedev:master
Choose a base branch
from
GastonZalba:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6ec8ddd
Added missing options and improved tests
GastonZalba c897e11
Updated README
GastonZalba cf00db0
Added more missing options and HQ Camera mode
GastonZalba 8965a83
Fix roi argument
GastonZalba 5ad5604
Requested changes applied
GastonZalba 71447e6
chore: stabilization comment spelling
gregnr 2032cfb
Added annotate and exif. Improved readme
GastonZalba 84f8146
Merge branch 'master' of https://github.com/GastonZalba/pi-camera-con…
GastonZalba 59de592
README details and format
GastonZalba 6483358
Fix uppercase in FlickerMode enum
GastonZalba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,4 @@ stats.json | |
# dev environments | ||
.vscode/* | ||
**/.DS_Store | ||
test_images/*.jpeg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
src/ | ||
test_images/ | ||
yarn.lock | ||
|
||
tsconfig.json | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,24 @@ | ||
import * as fs from 'fs'; | ||
import { performance } from 'perf_hooks'; | ||
|
||
import StillCamera from './still-camera'; | ||
|
||
const TEST_IMAGES_DIR = 'test_images'; | ||
|
||
if (!fs.existsSync(TEST_IMAGES_DIR)) { | ||
fs.mkdirSync(TEST_IMAGES_DIR); | ||
} | ||
|
||
test('takeImage() returns JPEG', async () => { | ||
const t0 = performance.now(); | ||
|
||
const stillCamera = new StillCamera(); | ||
|
||
const jpegImage = await stillCamera.takeImage(); | ||
const t1 = performance.now(); | ||
|
||
const time = ((t1 - t0) / 1000).toFixed(2); | ||
await fs.promises.writeFile(`test_images/stillCapture_(${time}-secs).jpeg`, jpegImage, 'binary'); | ||
|
||
expect(jpegImage.indexOf(StillCamera.jpegSignature)).toBe(0); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.