feat: Report event source headers on open. #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Feb 21, 2025
| /// Occurs when the connection to the EventSource API has been opened. | ||
| /// </summary> | ||
| public event EventHandler<EventArgs> ConnectionOpened; | ||
| public event EventHandler<EventSourceOpenedEventArgs> ConnectionOpened; |
Member
Author
There was a problem hiding this comment.
The EventSource service is internal, so there isn't any external impact from this change.
kinyoklion
commented
Feb 21, 2025
| /// A collection of header values when the ReadyState is Open, or null. | ||
| /// </value> | ||
| /// </summary> | ||
| public IEnumerable<KeyValuePair<string,IEnumerable<string>>> Headers { get; } |
Member
Author
There was a problem hiding this comment.
This is the public facing change.
kinyoklion
commented
Feb 21, 2025
| /// <param name="readyState">One of the <see cref="EventSource.ReadyState"/> values, which represents the state of the EventSource connection.</param> | ||
| public StateChangedEventArgs(ReadyState readyState) | ||
| /// <param name="headers">Response headers when the <see cref="StateChangedEventArgs.ReadyState"/> is <see cref="ReadyState.Open"/>. Otherwise null.</param> | ||
| public StateChangedEventArgs(ReadyState readyState, IEnumerable<KeyValuePair<string,IEnumerable<string>>> headers = null) |
Member
Author
There was a problem hiding this comment.
This constructor is public, but isn't something someone would really need to use in normal operation.
Likely it should have been internal.
tanderson-ld
approved these changes
Feb 21, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Feb 24, 2025
🤖 I have created a release *beep* *boop* --- ## [5.2.0](5.1.0...5.2.0) (2025-02-24) ### Features * Report event source headers on open. ([#104](#104)) ([e2cba63](e2cba63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.