Skip to content

fix: Avoid showing authorization value in exception #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 2 commits into from
Sep 25, 2025
Merged

fix: Avoid showing authorization value in exception #111

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f531060
fix: Avoid showing authorization value in exception
jsonbailey Sep 25, 2025
cb87053
add a unit test for coverage
jsonbailey Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/LaunchDarkly.EventSource/EventSourceService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,20 @@ private HttpRequestMessage CreateHttpRequestMessage(Uri uri, string lastEventId)
{
foreach (var item in _configuration.RequestHeaders)
{
request.Headers.Add(item.Key, item.Value);
try
{
request.Headers.Add(item.Key, item.Value);
}
catch (FormatException)
{
// Avoid showing the Authorization header value in the exception message
if (item.Key.Equals("Authorization", StringComparison.OrdinalIgnoreCase))
{
throw new FormatException("The Authorization header is invalid.");
}

throw;
}
}
}

Expand Down
Loading