chore: update meta and model to be immutable

Co-Authored-By: [email protected] <[email protected]>

Author: devin-ai-integration[bot]

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/LDAiClient.java

@@ -44,11 +44,6 @@ public LDAiClient(LDClientInterface client) {
     /**
      * Method to convert the JSON variable into the AiConfig object
      *
-     * Currently, I am doing this in a mutable way, just to verify the logic convert
-     * LDValue into AiConfig.
-     * It is possible we need a builder to create immutable version of this for ease
-     * of use in a later PR.
-     *
      * @param value
      * @param key
      */
@@ -67,13 +62,12 @@ protected AiConfig parseAiConfig(LDValue value, String key) {
                 throw new AiConfigParseException("_ldMeta must be a JSON object");
             }
 
-            Meta meta = new Meta();
-            // TODO: Do we expect customer calling this to build default value?
-            // If we do, then some of the values would be null
-            meta.setEnabled(ldValueNullCheck(valueMeta.get("enabled")).booleanValue());
-            meta.setVariationKey(ldValueNullCheck(valueMeta.get("variationKey")).stringValue());
-            Optional<Integer> version = Optional.of(valueMeta.get("version").intValue());
-            meta.setVersion(version);
+            // Create Meta using constructor
+            Meta meta = new Meta(
+                ldValueNullCheck(valueMeta.get("variationKey")).stringValue(),
+                Optional.of(valueMeta.get("version").intValue()),
+                ldValueNullCheck(valueMeta.get("enabled")).booleanValue()
+            );
             result.setMeta(meta);
 
             // Convert the optional messages from an JSON array of JSON objects into Message
@@ -97,25 +91,21 @@ protected AiConfig parseAiConfig(LDValue value, String key) {
                 throw new AiConfigParseException("model must be a JSON object");
             }
 
-            Model model = new Model();
-            model.setName(ldValueNullCheck(valueModel.get("name")).stringValue());
+            // Prepare parameters and custom maps for Model
+            String modelName = ldValueNullCheck(valueModel.get("name")).stringValue();
+            HashMap<String, LDValue> parameters = null;
+            HashMap<String, LDValue> custom = null;
 
             LDValue valueParameters = valueModel.get("parameters");
             if (valueParameters.getType() != LDValueType.NULL) {
                 if (valueParameters.getType() != LDValueType.OBJECT) {
                     throw new AiConfigParseException("non-null parameters must be a JSON object");
                 }
 
-                HashMap<String, LDValue> parameters = new HashMap<>();
+                parameters = new HashMap<>();
                 for (String k : valueParameters.keys()) {
                     parameters.put(k, valueParameters.get(k));
                 }
-                model.setParameters(parameters);
-            } else {
-                // Parameters is optional - so we can just set null and proceed
-
-                // TODO: Mustash validation somewhere
-                model.setParameters(null);
             }
 
             LDValue valueCustom = valueModel.get("custom");
@@ -124,15 +114,14 @@ protected AiConfig parseAiConfig(LDValue value, String key) {
                     throw new AiConfigParseException("non-null custom must be a JSON object");
                 }
 
-                HashMap<String, LDValue> custom = new HashMap<>();
+                custom = new HashMap<>();
                 for (String k : valueCustom.keys()) {
                     custom.put(k, valueCustom.get(k));
                 }
-                model.setCustom(custom);
-            } else {
-                // Custom is optional - we can just set null and proceed
-                model.setCustom(null);
             }
+            
+            // Create Model using constructor
+            Model model = new Model(modelName, parameters, custom);
             result.setModel(model);
 
             // Convert the optional provider from an JSON object of with name into Provider

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/datamodel/Meta.java

@@ -6,41 +6,40 @@ public final class Meta {
     /**
      * The variation key.
      */
-    private String variationKey;
+    private final String variationKey;
 
     /**
      * The variation version.
      */
-    private Optional<Integer> version;
+    private final Optional<Integer> version;
 
     /**
      * If the config is enabled.
      */
-    private boolean enabled;
+    private final boolean enabled;
 
-    // Getters and Setters
+    /**
+     * Constructor for Meta with all required fields.
+     * 
+     * @param variationKey the variation key
+     * @param version the version
+     * @param enabled if the config is enabled
+     */
+    public Meta(String variationKey, Optional<Integer> version, boolean enabled) {
+        this.variationKey = variationKey;
+        this.version = version != null ? version : Optional.empty();
+        this.enabled = enabled;
+    }
 
     public String getVariationKey() {
         return variationKey;
     }
 
-    public void setVariationKey(String variationKey) {
-        this.variationKey = variationKey;
-    }
-
     public Optional<Integer> getVersion() {
         return version;
     }
 
-    public void setVersion(Optional<Integer> version) {
-        this.version = version;
-    }
-
     public boolean isEnabled() {
         return enabled;
     }
-
-    public void setEnabled(boolean enabled) {
-        this.enabled = enabled;
-    }
 }

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/datamodel/Model.java

@@ -1,39 +1,40 @@
 package com.launchdarkly.sdk.server.ai.datamodel;
 
+import java.util.Collections;
 import java.util.HashMap;
+import java.util.Map;
 
 import com.launchdarkly.sdk.LDValue;
 
 public final class Model {
-    private String name;
+    private final String name;
 
-    private HashMap<String, LDValue> parameters;
+    private final Map<String, LDValue> parameters;
 
-    private HashMap<String, LDValue> custom;
+    private final Map<String, LDValue> custom;
 
-    // Getters and Setters
+    /**
+     * Constructor for Model with all required fields.
+     * 
+     * @param name the model name
+     * @param parameters the parameters map
+     * @param custom the custom map
+     */
+    public Model(String name, Map<String, LDValue> parameters, Map<String, LDValue> custom) {
+        this.name = name;
+        this.parameters = parameters != null ? Collections.unmodifiableMap(new HashMap<>(parameters)) : Collections.emptyMap();
+        this.custom = custom != null ? Collections.unmodifiableMap(new HashMap<>(custom)) : Collections.emptyMap();
+    }
 
     public String getName() {
         return name;
     }
 
-    public void setName(String name) {
-        this.name = name;
-    }
-
-    public HashMap<String, LDValue> getParameters() {
+    public Map<String, LDValue> getParameters() {
         return parameters;
     }
 
-    public void setParameters(HashMap<String, LDValue> parameters) {
-        this.parameters = parameters;
-    }
-
-    public HashMap<String, LDValue> getCustom() {
+    public Map<String, LDValue> getCustom() {
         return custom;
     }
-
-    public void setCustom(HashMap<String, LDValue> custom) {
-        this.custom = custom;
-    }
 }