Skip to content

chore: Enable publishing from release please #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

chore: Enable publishing from release please #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/actions/full-release/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ inputs:
prerelease:
description: 'Is this a prerelease. If so then it will be published to the staging repository only.'
required: true
run_tests:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual publish has an options to turn off tests that was not being honored. This supports the manual checkbox while defaulting to run tests in other circumstances.

description: 'If true, run unit tests, otherwise skip them.'
required: false
type: boolean
default: true
signing_key_id:
description: 'Signing key ID'
required: true
Expand Down Expand Up @@ -40,6 +45,7 @@ runs:
with:
workspace_path: ${{ inputs.workspace_path }}
java_version: 8
run_tests: ${{ inputs.run_tests }}

- name: Publish
uses: ./.github/actions/publish
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/manual-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
with:
workspace_path: ${{ inputs.workspace_path }}
dry_run: ${{ inputs.dry_run }}
run_tests: ${{ inputs.run_tests }}
prerelease: ${{ inputs.prerelease }}
signing_key_id: ${{ env.SIGNING_KEY_ID }}
signing_key_passphrase: ${{ env.SIGNING_KEY_PASSPHRASE }}
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ jobs:
runs-on: ubuntu-latest

outputs:
package-sdk-common-released: ${{ steps.release.outputs['lib/java-sdk-common--release_created'] }}
package-sdk-internal-released: ${{ steps.release.outputs['lib/java-sdk-internal--release_created'] }}
package-server-sdk-released: ${{ steps.release.outputs['lib/java-server-sdk--release_created'] }}
package-sdk-common-released: ${{ steps.release.outputs['lib/shared/common--release_created'] }}
package-sdk-internal-released: ${{ steps.release.outputs['lib/shared/internal--release_created'] }}
package-server-sdk-released: ${{ steps.release.outputs['lib/sdk/server--release_created'] }}
package-server-sdk-otel-released: ${{ steps.release.outputs['lib/java-server-sdk-otel--release_created'] }}
package-server-sdk-redis-store-released: ${{ steps.release.outputs['lib/java-server-sdk-redis-store--release_created'] }}

steps:
- uses: google-github-actions/release-please-action@v4
- uses: googleapis/release-please-action@v4
id: release
with:
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down Expand Up @@ -141,8 +141,8 @@ jobs:
- uses: ./.github/actions/full-release
with:
workspace_path: lib/shared/internal
dry_run: true #TODO make this false after testing
prerelease: true #TODO make this false after testing
dry_run: false
prerelease: false
code_signing_keyring: 'code-signing-keyring.gpg'
signing_key_id: ${{ env.SIGNING_KEY_ID }}
signing_key_passphrase: ${{ env.SIGNING_KEY_PASSPHRASE }}
Expand Down Expand Up @@ -174,8 +174,8 @@ jobs:
- uses: ./.github/actions/full-release
with:
workspace_path: lib/shared/common
dry_run: true #TODO make this false after testing
prerelease: true #TODO make this false after testing
dry_run: false
prerelease: false
code_signing_keyring: 'code-signing-keyring.gpg'
signing_key_id: ${{ env.SIGNING_KEY_ID }}
signing_key_passphrase: ${{ env.SIGNING_KEY_PASSPHRASE }}
Expand Down