feat: Add ESM support for common and sdk-client.

Author: kinyoklion

packages/sdk/browser/rollup.config.js

@@ -13,11 +13,6 @@ const getSharedConfig = (format, file) => ({
       file: file,
     },
   ],
-  onwarn: (warning) => {
-    if (warning.code !== 'CIRCULAR_DEPENDENCY') {
-      console.error(`(!) ${warning.message}`);
-    }
-  },
 });
 
 export default [

packages/sdk/browser/src/BrowserClient.ts

@@ -10,11 +10,11 @@ import {
   LDClientImpl,
   LDContext,
   LDEmitter,
+  LDEmitterEventName,
   LDHeaders,
+  LDIdentifyOptions,
   Platform,
 } from '@launchdarkly/js-client-sdk-common';
-import { LDIdentifyOptions } from '@launchdarkly/js-client-sdk-common/dist/api/LDIdentifyOptions';
-import { EventName } from '@launchdarkly/js-client-sdk-common/dist/LDEmitter';
 
 import BrowserDataManager from './BrowserDataManager';
 import GoalManager from './goals/GoalManager';
@@ -195,12 +195,12 @@ export class BrowserClient extends LDClientImpl {
     browserDataManager.setAutomaticStreamingState(!!this.emitter.listenerCount('change'));
   }
 
-  override on(eventName: EventName, listener: Function): void {
+  override on(eventName: LDEmitterEventName, listener: Function): void {
     super.on(eventName, listener);
     this.updateAutomaticStreamingState();
   }
 
-  override off(eventName: EventName, listener: Function): void {
+  override off(eventName: LDEmitterEventName, listener: Function): void {
     super.off(eventName, listener);
     this.updateAutomaticStreamingState();
   }

packages/sdk/browser/tsconfig.json

@@ -3,9 +3,8 @@
     "allowSyntheticDefaultImports": true,
     "declaration": true,
     "declarationMap": true,
-    "jsx": "react-jsx",
     "lib": ["ES2017", "dom"],
-    "module": "ES6",
+    "module": "ESNext",
     "moduleResolution": "node",
     "noImplicitOverride": true,
     "resolveJsonModule": true,

packages/shared/common/package.json

@@ -2,8 +2,13 @@
   "name": "@launchdarkly/js-sdk-common",
   "version": "2.9.0",
   "type": "commonjs",
-  "main": "./dist/index.js",
-  "types": "./dist/index.d.ts",
+  "main": "./dist/cjs/index.js",
+  "types": "./dist/types/index.d.ts",
+  "exports": {
+    "types": "./dist/types/index.d.ts",
+    "require": "./dist/cjs/index.js",
+    "import": "./dist/esm/index.js"
+  },
   "homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/shared/common",
   "repository": {
     "type": "git",
@@ -20,8 +25,9 @@
   ],
   "scripts": {
     "test": "npx jest --ci",
-    "build-types": "npx tsc --declaration true --emitDeclarationOnly true --declarationDir dist",
-    "build": "npx tsc",
+    "build": "npm run build-cjs && npm run build-esm",
+    "build-cjs": "npx tsc",
+    "build-esm": "npx tsc --project tsconfig.esm.json",
     "clean": "npx tsc --build --clean",
     "lint": "npx eslint . --ext .ts",
     "lint:fix": "yarn run lint --fix",

packages/shared/common/rollup.config.js

@@ -0,0 +1,16 @@
+{
+  "compilerOptions": {
+    "rootDir": "src",
+    "outDir": "dist/esm",
+    "target": "ES2017",
+    "lib": ["ES2020"],
+    "module": "ES6",
+    "moduleResolution": "NodeNext",
+    "strict": true,
+    "noImplicitOverride": true,
+    "sourceMap": true,
+    "stripInternal": true,
+    "composite": true
+  },
+  "exclude": ["**/*.test.ts", "dist", "node_modules", "__tests__"]
+}

packages/shared/common/tsconfig.esm.json

@@ -1,19 +1,18 @@
 {
   "compilerOptions": {
     "rootDir": "src",
-    "outDir": "dist",
+    "outDir": "dist/cjs",
     "target": "ES2017",
     "lib": ["es6"],
     "module": "commonjs",
     "strict": true,
     "noImplicitOverride": true,
-    // Needed for CommonJS modules: markdown-it, fs-extra
-    "allowSyntheticDefaultImports": true,
     "sourceMap": true,
     "declaration": true,
     "declarationMap": true, // enables importers to jump to source
     "stripInternal": true,
-    "composite": true
+    "composite": true,
+    "declarationDir": "./dist/types"
   },
   "exclude": ["**/*.test.ts", "dist", "node_modules", "__tests__"]
 }

packages/shared/common/tsconfig.json

@@ -2,8 +2,13 @@
   "name": "@launchdarkly/js-client-sdk-common",
   "version": "1.8.0",
   "type": "commonjs",
-  "main": "./dist/index.js",
-  "types": "./dist/index.d.ts",
+  "main": "./dist/cjs/index.js",
+  "types": "./dist/types/index.d.ts",
+  "exports": {
+    "types": "./dist/types/index.d.ts",
+    "require": "./dist/cjs/index.js",
+    "import": "./dist/esm/index.js"
+  },
   "homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/shared/sdk-client",
   "repository": {
     "type": "git",
@@ -21,7 +26,9 @@
   "scripts": {
     "doc": "../../../scripts/build-doc.sh .",
     "test": "npx jest --ci",
-    "build": "npx tsc",
+    "build": "npm run build-cjs && npm run build-esm",
+    "build-cjs": "npx tsc",
+    "build-esm": "npx tsc --project tsconfig.esm.json",
     "clean": "npx tsc --build --clean",
     "lint": "npx eslint . --ext .ts",
     "lint:fix": "yarn run lint -- --fix",

packages/shared/sdk-client/package.json

@@ -9,7 +9,6 @@ import {
   ProcessStreamResponse,
   subsystem,
 } from '@launchdarkly/js-sdk-common';
-import { LDStreamProcessor } from '@launchdarkly/js-sdk-common/dist/api/subsystem';
 
 import { LDIdentifyOptions } from './api/LDIdentifyOptions';
 import { Configuration } from './configuration/Configuration';
@@ -194,9 +193,9 @@ export abstract class BaseDataManager implements DataManager {
   }
 
   private decorateProcessorWithStatusReporting(
-    processor: LDStreamProcessor,
+    processor: subsystem.LDStreamProcessor,
     statusManager: DataSourceStatusManager,
-  ): LDStreamProcessor {
+  ): subsystem.LDStreamProcessor {
     return {
       start: () => {
         // update status before starting processor to ensure potential errors are reported after initializing