PR Feedback.

Author: kinyoklion

packages/shared/sdk-client/src/DataManager.ts

@@ -20,6 +20,14 @@ import { DataSourcePaths, StreamingProcessor } from './streaming';
 import { DeleteFlag, Flags, PatchFlag } from './types';
 
 export interface DataManager {
+  /**
+   * This function handles the data management aspects of the identification process.
+   *
+   * @param identifyResolve Called to reject the identify operation.
+   * @param identifyReject Called to complete the identify operation.
+   * @param context The context being identified.
+   * @param identifyOptions Options for identification.
+   */
   identify(
     identifyResolve: () => void,
     identifyReject: (err: Error) => void,
@@ -28,6 +36,9 @@ export interface DataManager {
   ): Promise<void>;
 }
 
+/**
+ * Factory interface for constructing data managers.
+ */
 export interface DataManagerFactory {
   (
     flagManager: FlagManager,

packages/shared/sdk-client/src/IdentityProcessor.ts

@@ -21,8 +21,7 @@ import {
 import { LDClient, type LDOptions } from './api';
 import { LDEvaluationDetail, LDEvaluationDetailTyped } from './api/LDEvaluationDetail';
 import { LDIdentifyOptions } from './api/LDIdentifyOptions';
-import ConfigurationImpl from './configuration';
-import { LDClientInternalOptions } from './configuration/Configuration';
+import { Configuration, ConfigurationImpl, LDClientInternalOptions } from './configuration';
 import { addAutoEnv } from './context/addAutoEnv';
 import { ensureKey } from './context/ensureKey';
 import { DataManager, DataManagerFactory } from './DataManager';
@@ -33,15 +32,15 @@ import {
 } from './evaluation/evaluationDetail';
 import createEventProcessor from './events/createEventProcessor';
 import EventFactory from './events/EventFactory';
-import DefaultFlagManager from './flag-manager/FlagManager';
+import DefaultFlagManager, { FlagManager } from './flag-manager/FlagManager';
 import { ItemDescriptor } from './flag-manager/ItemDescriptor';
 import LDEmitter, { EventName } from './LDEmitter';
 import { DeleteFlag, Flags, PatchFlag } from './types';
 
 const { ClientMessages, ErrorKinds } = internal;
 
 export default class LDClientImpl implements LDClient {
-  private readonly config: ConfigurationImpl;
+  private readonly config: Configuration;
   private uncheckedContext?: LDContext;
   private checkedContext?: Context;
   private readonly diagnosticsManager?: internal.DiagnosticsManager;
@@ -55,7 +54,7 @@ export default class LDClientImpl implements LDClient {
   private eventFactoryDefault = new EventFactory(false);
   private eventFactoryWithReasons = new EventFactory(true);
   private emitter: LDEmitter;
-  private flagManager: DefaultFlagManager;
+  private flagManager: FlagManager;
 
   private eventSendingEnabled: boolean = false;
   private baseHeaders: LDHeaders;

packages/shared/sdk-client/src/LDClientImpl.ts

@@ -56,15 +56,17 @@ export interface Configuration {
   readonly trackEventModifier: (event: internal.InputCustomEvent) => internal.InputCustomEvent;
 }
 
-export default class ConfigurationImpl implements Configuration {
-  public static DEFAULT_POLLING = 'https://clientsdk.launchdarkly.com';
-  public static DEFAULT_STREAM = 'https://clientstream.launchdarkly.com';
+const DEFAULT_POLLING: string = 'https://clientsdk.launchdarkly.com';
+const DEFAULT_STREAM: string = 'https://clientstream.launchdarkly.com';
+
+export { DEFAULT_POLLING, DEFAULT_STREAM };
 
+export default class ConfigurationImpl implements Configuration {
   public readonly logger: LDLogger = createSafeLogger();
 
-  public readonly baseUri = ConfigurationImpl.DEFAULT_POLLING;
+  public readonly baseUri = DEFAULT_POLLING;
   public readonly eventsUri = ServiceEndpoints.DEFAULT_EVENTS;
-  public readonly streamUri = ConfigurationImpl.DEFAULT_STREAM;
+  public readonly streamUri = DEFAULT_STREAM;
 
   public readonly maxCachedContexts = 5;
 

packages/shared/sdk-client/src/configuration/Configuration.ts

@@ -1,3 +1,14 @@
-import ConfigurationImpl from './Configuration';
+import ConfigurationImpl, {
+  Configuration,
+  DEFAULT_POLLING,
+  DEFAULT_STREAM,
+  LDClientInternalOptions,
+} from './Configuration';
 
-export default ConfigurationImpl;
+export {
+  Configuration,
+  ConfigurationImpl,
+  LDClientInternalOptions,
+  DEFAULT_POLLING,
+  DEFAULT_STREAM,
+};

packages/shared/sdk-client/src/configuration/index.ts

@@ -11,7 +11,7 @@ import {
   Platform,
 } from '@launchdarkly/js-sdk-common';
 
-import ConfigurationImpl from '../configuration';
+import { Configuration } from '../configuration';
 import digest from '../crypto/digest';
 import { getOrGenerateKey } from '../storage/getOrGenerateKey';
 import { namespaceForGeneratedContextKey } from '../storage/namespaceUtils';
@@ -39,7 +39,7 @@ export const toMulti = (c: LDSingleKindContext) => {
  */
 export const addApplicationInfo = async (
   { crypto, info }: Platform,
-  { applicationInfo }: ConfigurationImpl,
+  { applicationInfo }: Configuration,
 ): Promise<LDApplication | undefined> => {
   const { ld_application } = info.platformData();
   let app = deepCompact<LDApplication>(ld_application) ?? ({} as LDApplication);
@@ -103,11 +103,7 @@ export const addDeviceInfo = async (platform: Platform) => {
   return undefined;
 };
 
-export const addAutoEnv = async (
-  context: LDContext,
-  platform: Platform,
-  config: ConfigurationImpl,
-) => {
+export const addAutoEnv = async (context: LDContext, platform: Platform, config: Configuration) => {
   // LDUser is not supported for auto env reporting
   if (isLegacyUser(context)) {
     return context as LDUser;

packages/shared/sdk-client/src/context/addAutoEnv.ts

@@ -1,6 +1,6 @@
 import { secondsToMillis, ServiceEndpoints } from '@launchdarkly/js-sdk-common';
 
-import ConfigurationImpl from '../configuration';
+import { Configuration, DEFAULT_POLLING, DEFAULT_STREAM } from '../configuration';
 
 export type DiagnosticsInitConfig = {
   // client & server common properties
@@ -17,9 +17,9 @@ export type DiagnosticsInitConfig = {
   usingSecureMode: boolean;
   bootstrapMode: boolean;
 };
-const createDiagnosticsInitConfig = (config: ConfigurationImpl): DiagnosticsInitConfig => ({
-  customBaseURI: config.baseUri !== ConfigurationImpl.DEFAULT_POLLING,
-  customStreamURI: config.streamUri !== ConfigurationImpl.DEFAULT_STREAM,
+const createDiagnosticsInitConfig = (config: Configuration): DiagnosticsInitConfig => ({
+  customBaseURI: config.baseUri !== DEFAULT_POLLING,
+  customStreamURI: config.streamUri !== DEFAULT_STREAM,
   customEventsURI: config.eventsUri !== ServiceEndpoints.DEFAULT_EVENTS,
   eventsCapacity: config.capacity,
   eventsFlushIntervalMillis: secondsToMillis(config.flushInterval),

packages/shared/sdk-client/src/diagnostics/createDiagnosticsInitConfig.ts

@@ -1,11 +1,11 @@
 import { internal, Platform } from '@launchdarkly/js-sdk-common';
 
-import ConfigurationImpl from '../configuration';
+import { Configuration } from '../configuration';
 import createDiagnosticsInitConfig from './createDiagnosticsInitConfig';
 
 const createDiagnosticsManager = (
   clientSideID: string,
-  config: ConfigurationImpl,
+  config: Configuration,
   platform: Platform,
 ) => {
   if (config.sendEvents && !config.diagnosticOptOut) {

packages/shared/sdk-client/src/diagnostics/createDiagnosticsManager.ts

@@ -1,10 +1,10 @@
 import { ClientContext, internal, LDHeaders, Platform } from '@launchdarkly/js-sdk-common';
 
-import ConfigurationImpl from '../configuration';
+import { Configuration } from '../configuration';
 
 const createEventProcessor = (
   clientSideID: string,
-  config: ConfigurationImpl,
+  config: Configuration,
   platform: Platform,
   baseHeaders: LDHeaders,
   diagnosticsManager?: internal.DiagnosticsManager,

packages/shared/sdk-client/src/events/createEventProcessor.ts

@@ -6,22 +6,51 @@ import { DefaultFlagStore } from './FlagStore';
 import FlagUpdater, { FlagsChangeCallback } from './FlagUpdater';
 import { ItemDescriptor } from './ItemDescriptor';
 
+/**
+ * Top level manager of flags for the client. LDClient should be using this
+ * interface and not any of the specific instances managed by it. Updates from
+ * data sources should be directed to the [init] and [upsert] methods of this
+ * interface.
+ */
 export interface FlagManager {
+  /**
+   * Attempts to get a flag by key from the current flags.
+   */
   get(key: string): ItemDescriptor | undefined;
+
+  /**
+   * Gets all the current flags.
+   */
   getAll(): { [key: string]: ItemDescriptor };
+
+  /**
+   * Initializes the flag manager with data from a data source.
+   * Persistence initialization is handled by {@link FlagPersistence}
+   */
   init(context: Context, newFlags: { [key: string]: ItemDescriptor }): Promise<void>;
+
+  /**
+   * Attempt to update a flag. If the flag is for the wrong context, or
+   * it is of an older version, then an update will not be performed.
+   */
   upsert(context: Context, key: string, item: ItemDescriptor): Promise<boolean>;
+
+  /**
+   * Asynchronously load cached values from persistence.
+   */
   loadCached(context: Context): Promise<boolean>;
+
+  /**
+   * Register a flag change callback.
+   */
   on(callback: FlagsChangeCallback): void;
+
+  /**
+   * Unregister a flag change callback.
+   */
   off(callback: FlagsChangeCallback): void;
 }
 
-/**
- * Top level manager of flags for the client. LDClient should be using this
- * class and not any of the specific instances managed by it. Updates from
- * data sources should be directed to the [init] and [upsert] methods of this
- * class.
- */
 export default class DefaultFlagManager implements FlagManager {
   private flagStore = new DefaultFlagStore();
   private flagUpdater: FlagUpdater;
@@ -71,53 +100,30 @@ export default class DefaultFlagManager implements FlagManager {
     );
   }
 
-  /**
-   * Attempts to get a flag by key from the current flags.
-   */
   get(key: string): ItemDescriptor | undefined {
     return this.flagStore.get(key);
   }
 
-  /**
-   * Gets all the current flags.
-   */
   getAll(): { [key: string]: ItemDescriptor } {
     return this.flagStore.getAll();
   }
 
-  /**
-   * Initializes the flag manager with data from a data source.
-   * Persistence initialization is handled by {@link FlagPersistence}
-   */
   async init(context: Context, newFlags: { [key: string]: ItemDescriptor }): Promise<void> {
     return (await this.flagPersistencePromise).init(context, newFlags);
   }
 
-  /**
-   * Attempt to update a flag. If the flag is for the wrong context, or
-   * it is of an older version, then an update will not be performed.
-   */
   async upsert(context: Context, key: string, item: ItemDescriptor): Promise<boolean> {
     return (await this.flagPersistencePromise).upsert(context, key, item);
   }
 
-  /**
-   * Asynchronously load cached values from persistence.
-   */
   async loadCached(context: Context): Promise<boolean> {
     return (await this.flagPersistencePromise).loadCached(context);
   }
 
-  /**
-   * Register a flag change callback.
-   */
   on(callback: FlagsChangeCallback): void {
     this.flagUpdater.on(callback);
   }
 
-  /**
-   * Unregister a flag change callback.
-   */
   off(callback: FlagsChangeCallback): void {
     this.flagUpdater.off(callback);
   }