fix: MockFlags correctly mocks all types of flags

Author: professorice

packages/tooling/jest/src/react-native/index.test.ts

@@ -8,6 +8,10 @@ import {
 } from '.';
 
 describe('react-native', () => {
+  afterEach(() => {
+    resetLDMocks();
+  });
+
   test('reset LD Mocks', () => {
     const current = mockUseLDClient();
 
@@ -47,7 +51,6 @@ describe('react-native', () => {
   });
 
   test('mock ldClient correctly', () => {
-    resetLDMocks();
     const current = mockUseLDClient();
 
     current?.track('event');

packages/tooling/jest/src/react-native/index.ts

@@ -3,6 +3,11 @@ import {
   LDProvider,
   ReactNativeLDClient,
   useLDClient,
+  useBoolVariation,
+  useJsonVariation,
+  LDClient,
+  useNumberVariation,
+  useStringVariation,
 } from '@launchdarkly/react-native-client-sdk';
 
 jest.mock('@launchdarkly/react-native-client-sdk', () => ({
@@ -22,18 +27,23 @@ jest.mock('@launchdarkly/react-native-client-sdk', () => ({
   useTypedVariationDetail: jest.fn(),
 }));
 
-export const ldClientMock: any = {
+export const ldClientMock: jest.Mocked<LDClient> = {
   allFlags: jest.fn(),
   boolVariation: jest.fn(),
   boolVariationDetail: jest.fn(),
   close: jest.fn(),
-  flush: jest.fn(() => Promise.resolve()),
+  flush: jest.fn(() => Promise.resolve({ result: true })),
   getConnectionMode: jest.fn(),
   getContext: jest.fn(),
-  identify: jest.fn(() => Promise.resolve()),
+  identify: jest.fn().mockResolvedValue(undefined),
   jsonVariation: jest.fn(),
   jsonVariationDetail: jest.fn(),
-  logger: jest.fn(),
+  logger: {
+    error: jest.fn(),
+    warn: jest.fn(),
+    info: jest.fn(),
+    debug: jest.fn(),
+  },
   numberVariation: jest.fn(),
   numberVariationDetail: jest.fn(),
   off: jest.fn(),
@@ -50,6 +60,11 @@ export const mockLDProvider = LDProvider as jest.Mock;
 export const mockReactNativeLDClient = ReactNativeLDClient as jest.Mock;
 export const mockUseLDClient = useLDClient as jest.Mock;
 
+const mockUseBoolVariation = useBoolVariation as jest.Mock;
+const mockUseNumberVariation = useNumberVariation as jest.Mock;
+const mockUseStringVariation = useStringVariation as jest.Mock;
+const mockUseJsonVariation = useJsonVariation as jest.Mock;
+
 mockLDProvider.mockImplementation(({ children }) => children);
 mockReactNativeLDClient.mockImplementation(() => ldClientMock);
 mockUseLDClient.mockImplementation(() => ldClientMock);
@@ -59,21 +74,25 @@ export const mockFlags = (flags: LDFlagSet): any => {
     const defaultValue = flags[key];
     switch (typeof defaultValue) {
       case 'boolean':
+        mockUseBoolVariation.mockImplementation((flagKey: string) => flags[flagKey] as boolean);
         ldClientMock.boolVariation.mockImplementation(
           (flagKey: string) => flags[flagKey] as boolean,
         );
         break;
       case 'number':
+        mockUseNumberVariation.mockImplementation((flagKey: string) => flags[flagKey] as number);
         ldClientMock.numberVariation.mockImplementation(
           (flagKey: string) => flags[flagKey] as number,
         );
         break;
       case 'string':
+        mockUseStringVariation.mockImplementation((flagKey: string) => flags[flagKey] as string);
         ldClientMock.stringVariation.mockImplementation(
           (flagKey: string) => flags[flagKey] as string,
         );
         break;
       case 'object':
+        mockUseJsonVariation.mockImplementation((flagKey: string) => flags[flagKey] as object);
         ldClientMock.jsonVariation.mockImplementation(
           (flagKey: string) => flags[flagKey] as object,
         );