feat: Add ESM support for common and sdk-client. #603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 2, 2024
| file: file, | ||
| }, | ||
| ], | ||
| onwarn: (warning) => { |
There was a problem hiding this comment.
I had copied this config and this onwarn thing was a big problem. First there should not be circular references, but second it meant the logging left out all the useful stuff. Like where the error happened. Which made all errors not useful at all.
kinyoklion
commented
Oct 2, 2024
| LDIdentifyOptions, | ||
| Platform, | ||
| } from '@launchdarkly/js-client-sdk-common'; | ||
| import { LDIdentifyOptions } from '@launchdarkly/js-client-sdk-common/dist/api/LDIdentifyOptions'; |
There was a problem hiding this comment.
Building the new way helps find these bad imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses TSC to build both an ESM and CJS version of common and sdk-client.
I was going to use rollup for this, but removing rollup provides more debuggable code for non-browser cases. The browser build can do the minification.