Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { LDLogger } from '@launchdarkly/js-server-sdk-common';

import { EdgeKV } from '../../src/edgekv/edgekv';
import EdgeKVProvider from '../../src/edgekv/edgeKVProvider';

Expand All @@ -11,14 +13,21 @@ const NAMESPACE = 'namespace';
const GROUP = 'group';

describe('EdgeKVProvider', () => {
let logger: LDLogger;
beforeEach(() => {
mockEdgeKV.mockImplementation(() => ({
getText: jest.fn().mockResolvedValue('some-text'),
}));
logger = {
debug: jest.fn(),
info: jest.fn(),
warn: jest.fn(),
error: jest.fn(),
};
});

it('get string from edgeKV', async () => {
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP });
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP, logger });
expect(await edgeKVProvider.get('rootKey')).toEqual('some-text');
});

Expand All @@ -28,7 +37,7 @@ describe('EdgeKVProvider', () => {
getText: jest.fn().mockRejectedValueOnce(expectedError),
}));

const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP });
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP, logger });
const result = await edgeKVProvider.get('rootKey');
expect(result).toBe(undefined);
});
Expand Down
8 changes: 6 additions & 2 deletions packages/sdk/akamai-edgekv/src/edgekv/edgeKVProvider.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
import { EdgeProvider } from '@launchdarkly/akamai-edgeworker-sdk-common';
import { LDLogger } from '@launchdarkly/js-server-sdk-common';

import { EdgeKV } from './edgekv';

type EdgeKVProviderParams = {
namespace: string;
group: string;
logger: LDLogger;
};

export default class EdgeKVProvider implements EdgeProvider {
private _edgeKv: EdgeKV;
private _logger: LDLogger;

constructor({ namespace, group }: EdgeKVProviderParams) {
constructor({ namespace, group, logger }: EdgeKVProviderParams) {
this._edgeKv = new EdgeKV({ namespace, group } as any);
this._logger = logger;
}

async get(rootKey: string): Promise<string | null | undefined> {
try {
return await this._edgeKv.getText({ item: rootKey } as any);
} catch (e) {
/* empty */
this._logger?.error(`Error getting value from EdgeKV: ${e}`);
}
return undefined;
}
Expand Down
Loading