-
Notifications
You must be signed in to change notification settings - Fork 31
chore: Prepare for browser client releases. #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f04de7f
4f03a76
7fb0915
f7e571d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,6 @@ | |
| import './style.css'; | ||
| import TestHarnessWebSocket from './TestHarnessWebSocket'; | ||
|
|
||
| // const client = init('618959580d89aa15579acf1d', AutoEnvAttributes.Enabled); | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Forgot this at some point. Ok though client-side IDs are not secret. |
||
|
|
||
| async function runContractTests() { | ||
| const ws = new TestHarnessWebSocket('ws://localhost:8001'); | ||
| ws.connect(); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,16 +31,19 @@ import BrowserPlatform from './platform/BrowserPlatform'; | |
| * Applications should configure the client at page load time and reuse the same instance. | ||
| * | ||
| * For more information, see the [SDK Reference Guide](https://docs.launchdarkly.com/sdk/client-side/javascript). | ||
| * | ||
| * @ignore Implementation Note: We are not supporting dynamically setting the connection mode on the LDClient. | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This caused the entire type not to be in the docs. Moved these implementation notes. |
||
| * @ignore Implementation Note: The SDK does not support offline mode. Instead bootstrap data can be used. | ||
| * @ignore Implementation Note: The browser SDK has different identify options, so omits the base implementation | ||
| * @ignore from the interface. | ||
| */ | ||
| export type LDClient = Omit< | ||
| CommonClient, | ||
| 'setConnectionMode' | 'getConnectionMode' | 'getOffline' | 'identify' | ||
| > & { | ||
| /** | ||
| * @ignore | ||
| * Implementation Note: We are not supporting dynamically setting the connection mode on the LDClient. | ||
| * Implementation Note: The SDK does not support offline mode. Instead bootstrap data can be used. | ||
| * Implementation Note: The browser SDK has different identify options, so omits the base implementation | ||
| * from the interface. | ||
| */ | ||
|
|
||
| /** | ||
| * Specifies whether or not to open a streaming connection to LaunchDarkly for live flag updates. | ||
| * | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the name to match existing package.
It means client/server are not consistent, so we may want to add init to the client, or add initialize to the server, then mark as deprecated.