feat: add initial SDK library boilerplate and basic svelte LD SDK #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosnibor89
changed the title
Member
|
Hello @nosnibor89, Thank you for the contribution. Those contract tests aren't relevant to client-side SDKs, but they should all work correctly (and do run in CI and passed for your PR). When developing locally running I won't be able to review this deeply this week, but hopefully I can next week. Thank you, |
kinyoklion
reviewed
Oct 24, 2024
packages/sdk/svelte/__tests__/lib/client/SvelteLDClient.test.ts
Outdated
Show resolved
Hide resolved
kinyoklion
reviewed
Oct 31, 2024
kinyoklion
reviewed
Oct 31, 2024
kinyoklion
reviewed
Oct 31, 2024
kinyoklion
reviewed
Oct 31, 2024
kinyoklion
reviewed
Oct 31, 2024
intial refactor to use new "@launchdarkly/js-client-sdk"
…improve initialization logic
[refactor] Update SvelteLDClient to use proxy for flag variations. Allows to track flag evaluations
…js-core into feat/svelte-sdk
…ization with user context
…ents refactor: update SvelteLDClient to use compat SDK and improve initial…
kinyoklion
reviewed
Dec 19, 2024
kinyoklion
approved these changes
Dec 19, 2024
Contributor
Author
|
Awesome @kinyoklion . Thanks for improving and merging this one. Next, we'll create PR for "example" project and improve documentation. |
3 tasks
abarker-launchdarkly
pushed a commit
that referenced
this pull request
May 14, 2025
**Requirements** - [x] I have added test coverage for new or changed functionality (no behavior change is mostly example project and docs) - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** No issue. **Describe the solution you've provided** This pull request introduces a new Svelte example project to demonstrate the usage of `@launchdarkly/svelte-client-sdk`. The README of the example project includes steps to run such application that internally uses the SDK to interact with a boolean flag. Also, this PR adds documentation for `@launchdarkly/svelte-client-sdk` itself with a "Getting Started" session along with more advanced use of the SDK's api. **Describe alternatives you've considered** I don't know what to write here. **Additional context** This is a follow up PR for #632. Where Svelte SDK was introduced. After this, follow up PR for technical debt(upgrade Svelte 5 and improving test coverage ) should be expected --------- Co-authored-by: Robinson Marquez <[email protected]> Co-authored-by: Robinson Marquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
yarn run contract-testsfailed for me even inmain)Related issues
No issue
Describe the solution you've provided
Introducing the new
@launchdarkly/svelte-client-sdkpackage. Some of the details included in this PR are2.1
LDProvidercomponent2.2
LDFlagcomponent2.3 Svelte-compatible LD instance (exposes API to work with feature flags)
Describe alternatives you've considered
I don't know what to write here.
Additional context
This is the first of a series of PRs. Some of the following PR should be about
@launchdarkly/svelte-client-sdk