AI Tracking Updates #634
Closed
AI Tracking Updates #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 25, 2024 11:44
Add Bedrock and OpenAI methods fix npm scripts
kinyoklion
reviewed
Oct 28, 2024
| UnderscoreTokenUsage, | ||
| } from './api/metrics'; | ||
|
|
||
| export class LDAIConfigTracker { |
Member
There was a problem hiding this comment.
I need to check the base PR, but this should be implementing an interface, and the interface is what the customer is aware of.
kinyoklion
reviewed
Oct 28, 2024
kinyoklion
requested changes
Oct 28, 2024
| outputTokens: number; | ||
| totalTokens: number; | ||
|
|
||
| constructor(data: any) { |
Member
There was a problem hiding this comment.
A type of some kind would be good here. Typescript is structural, so it just needs to have the stuff that we need to understand.
| prompt_tokens: number; | ||
| completion_tokens: number; | ||
|
|
||
| constructor(data: any) { |
Member
There was a problem hiding this comment.
I am going to stop tagging now. But generally we want to avoid any, unless we really need to. Here we know several fields, so we should be able to say we need those.
cwaldren-ld
reviewed
Oct 31, 2024
| "name": "@launchdarkly/ai", | ||
| "version": "0.1.0", | ||
| "description": "LaunchDarkly AI SDK for Node.js", | ||
| "main": "dist/index.js", |
Contributor
There was a problem hiding this comment.
I think the package name should follow our normal conventions, likely @launchdarkly/node-server-sdk-ai. I can see this might require some discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge AI Tracking updates into overall model config branch.
durationOftrackOpenAIandtrackBedrockConverse.Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.