feat: Add a module for increased backward compatibility. #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 25, 2024
| "import": "./dist/index.es.js" | ||
| ".": { | ||
| "types": "./dist/src/index.d.ts", | ||
| "require": "./dist/index.cjs.js", |
Member
Author
There was a problem hiding this comment.
I may need to make this fancier when we verify CJS/ESM package inclusion. Given the problems we had in other packages.
tanderson-ld
approved these changes
Oct 29, 2024
Merged
kinyoklion
added a commit
that referenced
this pull request
Oct 29, 2024
The goals here are to: - Make the build simpler. - Make the build "modern". Currently we have worked around some build issues in other packages. Mainly with node module resolution. Despite the settings in the package.json node wants certain file extensions for certain types including .cts for the CJS type definitions. So far tsup seems to be the simplest way to get all things with expected names without a multi-step process. Or without having to make a hack package.json that just has the modules type. Please review #637 first.
kinyoklion
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk: 0.2.0</summary> ## [0.2.0](js-client-sdk-v0.1.0...js-client-sdk-v0.2.0) (2024-10-29) ### Features * Add a module for increased backward compatibility. ([#637](#637)) ([44a2237](44a2237)) * Refine CJS/ESM build configuration for browser SDK. ([#640](#640)) ([ec4377c](ec4377c)) * Vendor escapeStringRegexp to simplify builds. ([48cac54](48cac54)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.10.0 to 1.11.0 </details> <details><summary>js-client-sdk-common: 1.11.0</summary> ## [1.11.0](js-client-sdk-common-v1.10.0...js-client-sdk-common-v1.11.0) (2024-10-29) ### Features * Add a module for increased backward compatibility. ([#637](#637)) ([44a2237](44a2237)) </details> <details><summary>react-native-client-sdk: 10.9.1</summary> ## [10.9.1](react-native-client-sdk-v10.9.0...react-native-client-sdk-v10.9.1) (2024-10-29) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.10.0 to 1.11.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.