Skip to content

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Oct 31, 2024

This change, DefinitelyTyped/DefinitelyTyped#69997, to the @types/node package made typings for the emitter stricter and break the builds. Functionally the code is the same.

BEGIN_COMMIT_OVERRIDE
chore: Was reverted.
END_COMMIT_OVERRIDE

@github-actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 18517 bytes
Size limit: 21000

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15292 bytes
Size limit: 20000

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19278 bytes
Size limit: 21000

@kinyoklion kinyoklion marked this pull request as ready for review October 31, 2024 17:59
@kinyoklion kinyoklion requested a review from a team as a code owner October 31, 2024 17:59
@kinyoklion kinyoklion merged commit 2a9a0de into main Oct 31, 2024
20 checks passed
@kinyoklion kinyoklion deleted the rlamb/fix-node-typings branch October 31, 2024 18:06
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
kinyoklion added a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants