Skip to content

Conversation

@kinyoklion
Copy link
Member

I made a mistake with the types on the last one and this corrects those. It made the node package build, but it caused incompatible cascading types.

@kinyoklion kinyoklion requested a review from a team as a code owner October 31, 2024 19:13
@github-actions
Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 18517 bytes
Size limit: 21000

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15292 bytes
Size limit: 20000

@github-actions
Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19278 bytes
Size limit: 21000

@kinyoklion kinyoklion closed this Oct 31, 2024
@kinyoklion kinyoklion deleted the rlamb/typing-change-2 branch October 31, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants