Skip to content

chore: No package-size comments on forks. #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: No package-size comments on forks. #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions actions/package-size/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ runs:
echo "PACK_SIZE=$PACK_SIZE" >> $GITHUB_ENV

- name: Find Size Comment
# Only do commenting on non-forks. A fork does not have permissions for comments.
if: github.event.pull_request.head.repo.full_name == github.repository
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e
id: fc
with:
Expand All @@ -39,7 +41,7 @@ runs:
body-includes: '${{ inputs.package_name }} size report'

- name: Create comment
if: steps.fc.outputs.comment-id == ''
if: steps.fc.outputs.comment-id == '' && github.event.pull_request.head.repo.full_name == github.repository
Copy link
Member Author

@kinyoklion kinyoklion Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For forks the repo name will have a different owner and will not match.

Copy link
Member Author

@kinyoklion kinyoklion Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure if a composite can access this, so we will hopefully find out from the CI run.

Seemed to work.

uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
with:
issue-number: ${{ inputs.pr_number }}
Expand All @@ -50,7 +52,7 @@ runs:
Size limit: ${{ inputs.size_limit }}

- name: Update comment
if: steps.fc.outputs.comment-id != ''
if: steps.fc.outputs.comment-id != '' && github.event.pull_request.head.repo.full_name == github.repository
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043
with:
comment-id: ${{ steps.fc.outputs.comment-id }}
Expand Down