chore: Add react-universal to release-please config. #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
Author
|
I realized I have to make further fixes because of api changes. I'll resubmit this in due time. Sorry false alarm 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G'day sdk team, thank you for your continuing hard work to maintain the sdks. I recognize your efforts and appreciate you.
We are building a demo sandbox for customers to preview launchdarkly. tldr part of the work is to create data for this sandbox, including flag evals and coderefs. To generate these, we built a nextjs sample app. We really wanted to use the react-universal sdk, but alas it was not even alpha-available. I remember it was waiting for the modern js sdk to be published, and now the time is (kinda) here.
So the ask is to have both the browser sdk (in alpha) and also the react-universal sdk in alpha so we can use them.
Thank you for considering and reviewing this pr.